You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/05/28 02:10:05 UTC
[GitHub] [dubbo-go] EnableAsync opened a new pull request #1223: Ftr: Adding integration tests using dubbo-go-samples
EnableAsync opened a new pull request #1223:
URL: https://github.com/apache/dubbo-go/pull/1223
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Adding integration tests using dubbo-go-samples
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] EnableAsync commented on a change in pull request #1223: Ftr: Adding integration tests using dubbo-go-samples
Posted by GitBox <gi...@apache.org>.
EnableAsync commented on a change in pull request #1223:
URL: https://github.com/apache/dubbo-go/pull/1223#discussion_r642029672
##########
File path: integrate_test.sh
##########
@@ -33,34 +33,12 @@ echo "travis pull request repo slug -> ${GITHUB_REPOSITORY}"
echo "travis pull request actor -> ${GITHUB_ACTOR}"
echo "travis pull request repo param -> $1"
+# clone dubbo-go-samples
+git clone -b 3.0 https://github.com/apache/dubbo-go-samples.git samples
Review comment:
thanks for your review, now different branches of dubbo-go will use the dubbo-go-samples of the corresponding branch to test, and the default test scheme has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #1223: Ftr: Adding integration tests using dubbo-go-samples
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #1223:
URL: https://github.com/apache/dubbo-go/pull/1223#discussion_r641920069
##########
File path: integrate_test.sh
##########
@@ -33,34 +33,12 @@ echo "travis pull request repo slug -> ${GITHUB_REPOSITORY}"
echo "travis pull request actor -> ${GITHUB_ACTOR}"
echo "travis pull request repo param -> $1"
+# clone dubbo-go-samples
+git clone -b 3.0 https://github.com/apache/dubbo-go-samples.git samples
Review comment:
i think it should not change the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1223: Ftr: Adding integration tests using dubbo-go-samples
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1223:
URL: https://github.com/apache/dubbo-go/pull/1223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org