[GitHub] spark pull request: [SPARK-5817] [SQL] Fix bug of udtf with column...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4602#discussion_r27710379
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala ---
    @@ -441,10 +441,23 @@ class Analyzer(catalog: Catalog,
        */
       object ImplicitGenerate extends Rule[LogicalPlan] {
         def apply(plan: LogicalPlan): LogicalPlan = plan transform {
    -      case Project(Seq(Alias(g: Generator, _)), child) =>
    -        Generate(g, join = false, outer = false, None, child)
    +      case Project(Seq(Alias(g: Generator, name)), child) =>
    +        Generate(g, join = false, outer = false, child, None, name :: Nil)
    +      case Project(Seq(MultiAlias(g: Generator, names)), child) =>
    +        Generate(g, join = false, outer = false, child, None, names)
         }
       }
    +
    +  object ResolveGenerate extends Rule[LogicalPlan] {
    --- End diff --
    
    Can you add some scala doc here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org