You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/06 12:38:00 UTC
[GitHub] [activemq-artemis] gemmellr opened a new pull request #3689: ARTEMIS-3413: clean up mirror tests of create behaviour
gemmellr opened a new pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689
2ee22912f07d4418e1f71bd496e016ad3123fede just added a test called "testDeleteQueueWithRemoveFalse" (just abvoe the context of this change). That in itself seems fine, but what was odd is the diff context for the change ended with context showing an existing test "testDoNotSendDelete" that appeared to want to test the same thing.
However it doesnt actually do that at all, doing exactly the same thing as a third "testDoNotSendCreate" test, due to an argument not being used. This third test also doesnt do what its name suggests, with both of them instead verifying that a create command _is_ being sent.
This cleans things up so one test verifies the create is sent and the other that it isnt when configured, and renames them accordingly.
(Setting up a test server and monitoring that no mirroring command was sent when configured not to would probably be a better and faster test. But for another time..)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic closed pull request #3689: ARTEMIS-3413: clean up mirror tests of create behaviour
Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3689: ARTEMIS-3413: clean up mirror tests of create behaviour
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3689: ARTEMIS-3413: clean up mirror tests of create behaviour
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689#issuecomment-894233994
sorry I didn't mean to close it.. I meant to comment.. and then Merge...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3689: ARTEMIS-3413: clean up mirror tests of create behaviour
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3689:
URL: https://github.com/apache/activemq-artemis/pull/3689#issuecomment-894233437
thanks Robbie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org