You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2011/02/17 04:51:57 UTC
svn commit: r1071500 - in
/lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs:
fixed/FixedPostingsReaderImpl.java fixed/FixedPostingsWriterImpl.java
sep/SepPostingsReaderImpl.java sep/SepPostingsWriterImpl.java
Author: rmuir
Date: Thu Feb 17 03:51:56 2011
New Revision: 1071500
URL: http://svn.apache.org/viewvc?rev=1071500&view=rev
Log:
LUCENE-2905: don't write abs skip pointer until we have to, the block might be all low-freq terms
Modified:
lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsReaderImpl.java
lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsWriterImpl.java
lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsReaderImpl.java
lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsWriterImpl.java
Modified: lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsReaderImpl.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsReaderImpl.java?rev=1071500&r1=1071499&r2=1071500&view=diff
==============================================================================
--- lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsReaderImpl.java (original)
+++ lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsReaderImpl.java Thu Feb 17 03:51:56 2011
@@ -220,7 +220,7 @@ public class FixedPostingsReaderImpl ext
termState.skipFP += termState.bytesReader.readVLong();
}
} else if (isFirstTerm) {
- termState.skipFP = termState.bytesReader.readVLong();
+ termState.skipFP = 0;
}
}
Modified: lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsWriterImpl.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsWriterImpl.java?rev=1071500&r1=1071499&r2=1071500&view=diff
==============================================================================
--- lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsWriterImpl.java (original)
+++ lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/fixed/FixedPostingsWriterImpl.java Thu Feb 17 03:51:56 2011
@@ -301,12 +301,8 @@ public final class FixedPostingsWriterIm
}
lastSkipFP = skipFP;
} else if (isFirstTerm) {
- // TODO: this is somewhat wasteful; eg if no terms in
- // this block will use skip data, we don't need to
- // write this:
- final long skipFP = skipOut.getFilePointer();
- indexBytesWriter.writeVLong(skipFP);
- lastSkipFP = skipFP;
+ // lazily write an absolute delta if a term in this block requires skip data.
+ lastSkipFP = 0;
}
lastDocID = 0;
Modified: lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsReaderImpl.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsReaderImpl.java?rev=1071500&r1=1071499&r2=1071500&view=diff
==============================================================================
--- lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsReaderImpl.java (original)
+++ lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsReaderImpl.java Thu Feb 17 03:51:56 2011
@@ -243,7 +243,7 @@ public class SepPostingsReaderImpl exten
}
//System.out.println(" skipFP=" + termState.skipFP);
} else if (isFirstTerm) {
- termState.skipFP = termState.bytesReader.readVLong();
+ termState.skipFP = 0;
}
}
Modified: lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsWriterImpl.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsWriterImpl.java?rev=1071500&r1=1071499&r2=1071500&view=diff
==============================================================================
--- lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsWriterImpl.java (original)
+++ lucene/dev/branches/bulkpostings/lucene/src/java/org/apache/lucene/index/codecs/sep/SepPostingsWriterImpl.java Thu Feb 17 03:51:56 2011
@@ -290,12 +290,8 @@ public final class SepPostingsWriterImpl
}
lastSkipFP = skipFP;
} else if (isFirstTerm) {
- // TODO: this is somewhat wasteful; eg if no terms in
- // this block will use skip data, we don't need to
- // write this:
- final long skipFP = skipOut.getFilePointer();
- indexBytesWriter.writeVLong(skipFP);
- lastSkipFP = skipFP;
+ // lazily write an absolute delta if a term in this block requires skip data.
+ lastSkipFP = 0;
}
lastDocID = 0;