You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@livy.apache.org by vanzin <gi...@git.apache.org> on 2018/10/05 20:37:39 UTC

[GitHub] incubator-livy pull request #110: [LIVY-508][Server] Support custom auth fil...

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/incubator-livy/pull/110#discussion_r223131905
  
    --- Diff: server/src/main/scala/org/apache/livy/server/LivyServer.scala ---
    @@ -238,11 +239,25 @@ class LivyServer extends Logging {
             server.context.addFilter(holder, "/*", EnumSet.allOf(classOf[DispatcherType]))
             info(s"SPNEGO auth enabled (principal = $principal)")
     
    -     case null =>
    +      case null =>
             // Nothing to do.
     
    -      case other =>
    -        throw new IllegalArgumentException(s"Invalid auth type: $other")
    +      case e =>
    --- End diff --
    
    Use a more descriptive name (e.g. `customType`)?


---