You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/02 09:19:20 UTC

[jira] [Commented] (EAGLE-581) Generate a build number when building the project.

    [ https://issues.apache.org/jira/browse/EAGLE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540069#comment-15540069 ] 

ASF GitHub Bot commented on EAGLE-581:
--------------------------------------

GitHub user pkuwm opened a pull request:

    https://github.com/apache/incubator-eagle/pull/469

    [EAGLE-581] Generate buildnumber when building the project.

    <!--
    {% comment %}
    Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
    this work for additional information regarding copyright ownership.
    The ASF licenses this file to you under the Apache License, Version 2.0
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
    
    http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
    {% endcomment %}
    -->
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[EAGLE-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pkuwm/incubator-eagle EAGLE-581

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #469
    
----
commit 7c31006fb406148e513c44f3e8099da10dc962f6
Author: pkuwm <ih...@gmail.com>
Date:   2016-10-02T09:17:23Z

    [EAGLE-581] Generate buildnumber when building the project.

----


> Generate a build number when building the project.
> --------------------------------------------------
>
>                 Key: EAGLE-581
>                 URL: https://issues.apache.org/jira/browse/EAGLE-581
>             Project: Eagle
>          Issue Type: New Feature
>    Affects Versions: v0.5.0
>            Reporter: Huizhi Lu
>            Assignee: Huizhi Lu
>             Fix For: v0.5.0
>
>
> Use case:
> we need to know what version(latest commit revision) of source code we are using for the current build so that it will be convenient for us to clarify different builds. So when you might make 100 builds of version 0.5.0-SNAPSHOT, you can differentiate between them all.
> Solution:
> Use buildnumber-maven-plugin
> 1. Add Maven plugin buildnumber-maven-plugin to pom.xml file
> 2. Add manifest entries to META-INF/MANIFEST.MF
> Build-Branch: EAGLE-581
> Build-Commit: f6fad2ebe8a384a6d17e40c609041ff77f6a692c
> Build-Time: 2016-10-02 09:05:31 AM, UTC
> 3. Placehold VERSION.
> The build info is stored in RELEASE File in the root directory. RELEASE is like:
> project.version: 0.5.0-incubating-SNAPSHOT
> build.branch: EAGLE-581
> build.commit: f6fad2ebe8a384a6d17e40c609041ff77f6a692c
> build.time: 2016-10-02 01:39:40 AM, PDT



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)