You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/11/25 21:37:54 UTC
DO NOT REPLY [Bug 118640] New: Opening the presentation document
causes OpenOffice 3.3 on Windows or Solaris to crash
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Bug #: 118640
Issue Type: DEFECT
Summary: Opening the presentation document causes OpenOffice
3.3 on Windows or Solaris to crash
Classification: Application
Product: Presentation
Version: OOO330m20
Platform: PC
OS/Version: Solaris
Status: UNCONFIRMED
Severity: major
Priority: P5
Component: open-import
AssignedTo: graphicsneedsconfirm@openoffice.org
ReportedBy: stream@willows7.myzen.co.uk
CC: ooo-issues@incubator.apache.org
Created attachment 77046
--> https://issues.apache.org/ooo/attachment.cgi?id=77046
Secondary School Maths Presentation
My daughter brought home a maths homework powerpoint presentation which caused
OpenOffice Impress 330m20 to crash on both Windows XP and OpenIndiana b151a.
However when I booted the Windows XP into Linux which had OpenOffice 3.2
installed it was capable of opening the document
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #19 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1571426 into trunk:
i118640 force early destruction of last FragmentHandler to not let it use an
...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #13 from Armin Le Grand <Ar...@me.com> ---
Destruction of the last of three SlideFragmentHandler crashes; the destructor
is used to actually do something, lets see...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #16 from Armin Le Grand <Ar...@me.com> ---
Has nothing to do with STL, the buffer accessed is already destroyed. That
again happens due to the mechanism used to import the stuff: For every part to
be imported a FragmentHandler derivate (as needed for the context) is created
and set at the parser. This triggers the deletion of the previous
FragmentHandler which will create imported elements in its destructor.
At the end of import the parser is destroyed and that will execute the last
FragmentHandler destructor which will create imported objects. That last
FragmentHandler is the form control importer which is normally empty and does
nothing, thus will not stumble over the already destroyed buffer
maRelationsMap. In the bugdoc this is different; there is content for this and
it will try to use the already destroyed maRelationsMap.
Thus this should happen with all pptx containing FormControls, trying to create
one as example (how to iinsert a form control to ms ppt2010?)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #15 from Armin Le Grand <Ar...@me.com> ---
Inn XmlFilterBase::importRelations it tries to use mxImpl->maRelationsMap in
xmlfilterbase.cxx in oox which is a 'typedef RefMap< OUString, Relations >
RelationsMap' where RefMap is an own template class in oox/helper/refmap.hxx,
the operator[] on the empty maRelationsMap crashes.
Interestingly the definition does not have an operator[] directly but is
derived of type ::std::map which has one.
maRelationsMap gets never filled, thus it must always have been empty. Maybe
the change to the standard STL makes this operator crash now...?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #9 from Armin Le Grand <Ar...@me.com> ---
The ~FastSaxParser() in sax fails in destruction of his member ParserData, that
is a struct holding uno references, a locale and has con/destructor. It also
has an inmplicit copy construtor used in FastSaxParser::pushEntity when it gets
pushed to a ::std::stack< Entity > in FastSaxParser::parseStream. The
origilally local Entity incarnation in the same method explicitely uses
XML_ParserFree( entity.mpParser ) what the destructor of the copy-constructed
Entity incarnation does not do.
Also checked where 'XML_ParserFree' comes from, it seems to be a macro in
Python (thus may also be python-version related). I am no expert in this area.
My guess is that class FastSaxParser should not use a ::std::stack< Entity >
which implicitely copy-constructs Entity-incarnations and destroys them, but
better should use a ::std::stack< Entity& > type. Lets try that...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #2 from Armin Le Grand <Ar...@me.com> ---
Can confirm on win7. Got the following asserts:
Error: PropertySet::implSetPropertyValue - cannot set property "NumberingLevel"
>From File C:/aoo/svn_trunk47/main/oox/source/helper/propertyset.cxx at Line 171
Error: PropertySet::implSetPropertyValue - cannot set property "CharCaseMap"
>From File C:/aoo/svn_trunk47/main/oox/source/helper/propertyset.cxx at Line 171
Error: PropertySet::implSetPropertyValue - cannot set property "IsNumbering"
>From File C:/aoo/svn_trunk47/main/oox/source/helper/propertyset.cxx at Line 171
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 118640] Opening the presentation document causes OpenOffice
3.3 on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #22 from Oliver-Rainer Wittmann <or...@apache.org> ---
I can verify the fix on local build of branch AOO410, rev. 1582710
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #3 from Armin Le Grand <Ar...@me.com> ---
Indeed NumberingLevel is member of SVX_UNOEDIT_OUTLINER_PROPERTIES (both in
editeng), but not member of SVX_UNOEDIT_NUMBERING_PROPERTIE which is used in sd
to define a SvxItemPropertySet whcih is accessed in GetStylePropertySet() and
thus used for UNO API style access, so in SdStyleSheet::setPropertyValue an
UnknownPropertyException is thrown. But this is not the reason for the crash,
these are catched. Need sfx2, svl with debug...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |Armin.Le.Grand@me.com
|g |
Target Milestone|--- |4.1.0
--- Comment #21 from Armin Le Grand <Ar...@me.com> ---
Adapting flags
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 118640] Opening the presentation document causes OpenOffice
3.3 on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #23 from Oliver-Rainer Wittmann <or...@apache.org> ---
Verified on Ubuntu 10.04 (64bit) with build from branch AOO410 (rev. 1583666)
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #7 from Armin Le Grand <Ar...@me.com> ---
The XFilter release seems to crash; In the WeakImplHelper5 the release() has a
cppu::OWeakObject {m_refCount=1 m_pWeakConnectionPoint=0x00000000
m_pReserved=0x77777777 }, I am not sure if m_pReserved is used and if that
value is good. One quick test shows that jumping over the XFilter release (in
assembly mode) makes the document load well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
DO NOT REPLY [Bug 118640] Opening the presentation document causes
OpenOffice 3.3 on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Marcus <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |crash, ms_interoperability
Priority|P5 |P3
Status|UNCONFIRMED |NEW
Platform|PC |All
Version|OOO330m20 |OOo 3.3
Ever Confirmed|0 |1
OS/Version|Solaris |All
--- Comment #1 from Marcus <ma...@apache.org> 2011-11-25 22:31:41 UTC ---
I can confirm the crash also on Linux.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #12 from Armin Le Grand <Ar...@me.com> ---
Jumped over the asm code that frees the weak reference mxDocumentHandler in
~ParserData(), all works well. That reference shows to a SlideFragmentHandler,
checking lifetimes...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
Was also a false trace; its definitely the destruction of the local member
maData of FastSaxParser, there it seems to be the mxDocumentHandler. That
incarnation of the parser was used to load Fragments, these may have set
mxDocumentHandler to something that is no longer there(?)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #18 from Armin Le Grand <Ar...@me.com> ---
Created a new pptx with MSPPT2010 with one form control and the same crash
happens; this proves the theory, so I can apply the intended fix. Preparing and
re-cheching again...
BTW: The newly created pptx throws the same exceptions as mentioned in comment
2.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #10 from Armin Le Grand <Ar...@me.com> ---
There is one Entity instance left after parsing the file, so there must be a
case where inside FastSaxParser::parseStream not the needed pair of calls to
pushEntity/popEntity is done; this can only happen when an exception of so far
unknown type is thrown, that may have to do with the exceptions triggered by
the asserted non-working attribute changes. Adding another catch case and
checking...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #20 from Armin Le Grand <Ar...@me.com> ---
Rechecked, committed, done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
What goes wrong is the destruction of the PowerPointImport implementation
object, more precise the oox::core::XmlFilterBase from which it is derived.
There in XmlFilterBaseImpl it's the member FastParser. XmlFilterBaseImpl has an
implicit destructor, need to follow all this in assembly...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #14 from Armin Le Grand <Ar...@me.com> ---
The problem is with the 1st of three SlideFragmentHandler, it inserts four
shapes, problem is the first. It uses the GraphicPath "ppt/media/image1.wmf"
and has the name "DefaultOcx" and is a FormControl. It crashes on construction
of AxControlFragment in ComplexShape::implConvertAndInsert.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
One more hint: Avoiding the parts that throw assertions makes no difference,
still crashing.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
In SfxObjectShell::ImportFrom at the end standing on the return statement does
not get back to SfxObjectShell::DoLoad which is on the stack, but crashes.
Might be the cleanup of one of the local objects...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #17 from Armin Le Grand <Ar...@me.com> ---
Possible fix: Add a mxImpl->maFastParser.setDocumentHandler(0) to
XmlFilterBase::~XmlFilterBase() to force the execution of the destructor and
thus object creation of the last FragmentHandler before XmlFilterBase::mxImpl
gets destroyed which is holding the needed context data. Checked, that works
well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 118640] Opening the presentation document causes OpenOffice 3.3
on Windows or Solaris to crash
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118640
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
Cannot really nail it, its somewhere around parsing the master page contained,
my closest breakpoint is at objstor.cxx lin 738, where it does not come back
but somehow uses corrupted mem or an exception exit...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.