[GitHub] [skywalking] hanahmily commented on a change in pull request #4364: Support Downsampling Data Packing feature in ES storage implementation

[GitBox <gi...@apache.org>]

hanahmily commented on a change in pull request #4364: Support Downsampling Data Packing feature in ES storage implementation
URL: https://github.com/apache/skywalking/pull/4364#discussion_r379965111
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/application.yml
 ##########
 @@ -104,6 +105,7 @@ storage:
     protocol: ${SW_STORAGE_ES_HTTP_PROTOCOL:"http"}
     #trustStorePath: ${SW_SW_STORAGE_ES_SSL_JKS_PATH:"../es_keystore.jks"}
     #trustStorePass: ${SW_SW_STORAGE_ES_SSL_JKS_PASS:""}
+    enablePackedDownsampling: ${SW_STORAGE_ENABLE_PACKED_DOWNSAMPLING:true} # Hour and Day metrics will be merged into minute index.
     user: ${SW_ES_USER:""}
     password: ${SW_ES_PASSWORD:""}
     indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
 
 Review comment:
   Do we need to increase it when packed downsampling enabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services