[GitHub] [accumulo] ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1330: Fix #1090 Consolidate/Simplfy ServerOpts
URL: https://github.com/apache/accumulo/pull/1330#discussion_r320521596
 
 

 ##########
 File path: core/src/main/java/org/apache/accumulo/core/cli/ConfigOpts.java
 ##########
 @@ -57,6 +69,9 @@ public synchronized String getPropertiesPath() {
           + " set in Zookeeper). Expected format: -o <key>=<value>")
   private List<String> overrides = new ArrayList<>();
 
+  // holds property overrides that may be generated from deprecation:
+  private static List<String> deprecated_overrides = new ArrayList<>();
 
 Review comment:
   > This definitely simplifies things and keeps the code tidier. Since these are command line options, dropping them instead of "deprecating" them is not so bad since they are easily updated by the customer vs. "deprecated" java code.
   
   I think you just convinced me that this is the right course of action.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services