You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Tony Gale (JIRA)" <ji...@apache.org> on 2018/10/01 10:36:00 UTC
[jira] [Commented] (GUACAMOLE-637) Compile error: 'strncpy' output
may be truncated copying 7 bytes from a string of length 7
[ https://issues.apache.org/jira/browse/GUACAMOLE-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16633835#comment-16633835 ]
Tony Gale commented on GUACAMOLE-637:
-------------------------------------
Possible patch for consideration:
--- svc_service.c 2018-09-28 02:25:30.000000000 +0100
+++ svc_service.c 2018-10-01 11:32:34.839596780 +0100
@@ -55,6 +55,8 @@
/* Init channel def */
strncpy(svc_plugin->plugin.channel_def.name, svc->name,
GUAC_RDP_SVC_MAX_LENGTH);
+ svc_plugin->plugin.channel_def.name[GUAC_RDP_SVC_MAX_LENGTH] = '\0';
+
svc_plugin->plugin.channel_def.options =
CHANNEL_OPTION_INITIALIZED
| CHANNEL_OPTION_ENCRYPT_RDP
> Compile error: 'strncpy' output may be truncated copying 7 bytes from a string of length 7
> ------------------------------------------------------------------------------------------
>
> Key: GUACAMOLE-637
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-637
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole-server
> Affects Versions: 1.0.0
> Environment: Fedora 28
> Reporter: Tony Gale
> Priority: Major
>
> Build error on Fedora 28:
> CC guac_svc/guacsvc_client_la-svc_service.lo
> guac_svc/svc_service.c: In function 'VirtualChannelEntry':
> guac_svc/svc_service.c:56:5: error: 'strncpy' output may be truncated copying 7 bytes from a string of length 7 [-Werror=stringop-truncation]
> strncpy(svc_plugin->plugin.channel_def.name, svc->name,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> GUAC_RDP_SVC_MAX_LENGTH);
> ~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)