You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/12 00:49:59 UTC

[GitHub] [beam] youngoli commented on a change in pull request #11989: [BEAM-9615] Add String UTF8 coder.

youngoli commented on a change in pull request #11989:
URL: https://github.com/apache/beam/pull/11989#discussion_r439145448



##########
File path: sdks/go/pkg/beam/core/runtime/coderx/string.go
##########
@@ -23,6 +23,8 @@ import (
 
 // NewString returns a coder for the string type. It uses the native
 // []byte to string conversion.
+//
+// Only for custom coder test use.
 func NewString() (*coder.CustomCoder, error) {

Review comment:
       If this is only meant to be used for custom coder tests, should it just be renamed instead? It seems unlikely to be used by user code right now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org