You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by jo...@apache.org on 2019/08/12 18:12:39 UTC
[royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-compiler.git
The following commit(s) were added to refs/heads/develop by this push:
new f4f9898 MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
f4f9898 is described below
commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Mon Aug 12 11:12:34 2019 -0700
MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Now, if a definition is resolved, and its parent definition is a package, just outputs the fully-qualified name instead of walking the full chain of member access
---
.../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
debugger/.factorypath | 102 +++++++++++++++++++++
2 files changed, 111 insertions(+), 4 deletions(-)
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
index 741affb..cc0a892 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
@@ -23,6 +23,7 @@ import org.apache.royale.compiler.codegen.ISubEmitter;
import org.apache.royale.compiler.codegen.js.IJSEmitter;
import org.apache.royale.compiler.constants.IASLanguageConstants;
import org.apache.royale.compiler.definitions.IDefinition;
+import org.apache.royale.compiler.definitions.IPackageDefinition;
import org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
@@ -32,7 +33,6 @@ import org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
import org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
import org.apache.royale.compiler.internal.definitions.AccessorDefinition;
-import org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
import org.apache.royale.compiler.internal.definitions.FunctionDefinition;
import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
import org.apache.royale.compiler.internal.tree.as.*;
@@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
import org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
import org.apache.royale.compiler.utils.ASNodeUtils;
-import javax.sound.midi.SysexMessage;
-
public class MemberAccessEmitter extends JSSubEmitter implements
ISubEmitter<IMemberAccessExpressionNode>
{
@@ -177,6 +175,13 @@ public class MemberAccessEmitter extends JSSubEmitter implements
return;
}
}
+ else if(def.getParent() instanceof IPackageDefinition)
+ {
+ //this is a fully qualified name, and we should output it directly
+ //because we don't want it to be treated as dynamic access
+ write(fjs.formatQualifiedName(def.getQualifiedName()));
+ return;
+ }
else if (def.getParent() != null &&
def.getParent().getQualifiedName().equals("Array"))
{
@@ -260,7 +265,7 @@ public class MemberAccessEmitter extends JSSubEmitter implements
getEmitter().emitClosureEnd(leftNode, def);
}
return;
- }
+ }
boolean isCustomNamespace = false;
if (def instanceof FunctionDefinition && node.getOperator() == OperatorType.MEMBER_ACCESS)
isCustomNamespace = fjs.isCustomNamespace((FunctionDefinition)def);
diff --git a/debugger/.factorypath b/debugger/.factorypath
new file mode 100644
index 0000000..2103813
--- /dev/null
+++ b/debugger/.factorypath
@@ -0,0 +1,102 @@
+<factorypath>
+ <factorypathentry kind="VARJAR" id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar" enabled="true" runInBatchMode="false"/>
+</factorypath>
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
Posted by Alex Harui <ah...@adobe.com.INVALID>.
I could be wrong, but I think for Eclipse and maybe some other IDEs, some files are necessary to get a project up and running and others are generated by use of the IDE.
For example, I don't think I've seen a .factorypath class before, but the .project (and maybe the .classpath) files are required for importing a project into an Eclipse workspace. I believe that we don't want to remove files required for importing, especially if we can format those files for universal use so they don't contain some committer's file/folder structure. But I think we can still add those files to .gitignore so changes are not accidentally commited. But to add a new one, there are some git options to force them to be committed. So we could adopt that strategy if we want to. Either way there is some manual steps to keep certain files as templates for importing.
Of course, I could be wrong...
-Alex
On 9/9/19, 10:03 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi,
I notice all that files too from Eclips, can we remove all that files and
add all config files to .gitignore.
In doing that you ensure that your config files are the ones you use and
you don't get any other one from our repo.
I think we removed all other IDE files (VScode), specially the ones that
are tied to user paths.
Moonshine are as well in, but don't know right now if are tied to user
paths or not.
El lun., 9 sept. 2019 a las 18:04, Josh Tynjala (<jo...@bowlerhat.dev>)
escribió:
> Maybe. It's worth mentioning that VSCode's Java support is based on
> Eclipse, so it uses the same project file formats as Eclipse. We have
> .classpath and .project files committed in the repo, presumably to make it
> easy to import the compiler projects into Eclipse. However, they're
> constantly in a modified state in my local copy because VSCode overwrites
> them. I think that VSCode re-configures the project based on the Maven
> pom.xml file, but the repo's versions don't know about Maven.
>
> Even if we add .factorypath to .gitignore, both .classpath and .project are
> at risk of being accidentally committed too. It wouldn't really make a huge
> difference for me to ignore this file because I will still need to take
> extra care before committing. It just happened to slip through this time.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C1466ad2654ad4c34bf6108d73547b02f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036454346349810&sdata=DVQNmmorvdrGC3%2FjZ3%2FBypmn28rYCmgJesIj91XoIHQ%3D&reserved=0>
>
>
> On Mon, Sep 9, 2019 at 8:27 AM Alex Harui <ah...@adobe.com.invalid>
> wrote:
>
> > Should it be added to .gitignore so it doesn't get committed?
> >
> > On 9/9/19, 6:58 AM, "Josh Tynjala" <jo...@bowlerhat.dev> wrote:
> >
> > I removed this file. Should be gone on both develop and release/
> 0.9.6.
> >
> > - Josh
> >
> >
> > On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <
> joshtynjala@bowlerhat.dev
> > >
> > wrote:
> >
> > > It's a project file created by VSCode. I didn't realize that I
> > > accidentally added it. It can be removed from the repo.
> > >
> > > - Josh
> > >
> > > On Saturday, September 7, 2019, Alex Harui
> <aharui@adobe.com.invalid
> > >
> > > wrote:
> > > > Josh,
> > > >
> > > > What is the .factorypath file? It is in the release package.
> > Should it
> > > even be in the repo?
> > > >
> > > > -Alex
> > > >
> > > > On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <
> > joshtynjala@apache.org>
> > > wrote:
> > > >
> > > > This is an automated email from the ASF dual-hosted git
> > repository.
> > > >
> > > > joshtynjala pushed a commit to branch develop
> > > > in repository
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C1466ad2654ad4c34bf6108d73547b02f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036454346349810&sdata=klHqmmUArzXIr0Mzn8MmBNqYuSmFNT9I4amLSYJXoYo%3D&reserved=0
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/develop by
> > this
> > > push:
> > > > new f4f9898 MemberAccessEmitter: fixed issue where
> > > fully-qualified names were emitted as dynamic access with
> > > -js-dynamic-access-unknown-members=true
> > > > f4f9898 is described below
> > > >
> > > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > > Author: Josh Tynjala <jo...@apache.org>
> > > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > > >
> > > > MemberAccessEmitter: fixed issue where fully-qualified
> > names
> > > were emitted as dynamic access with
> > -js-dynamic-access-unknown-members=true
> > > >
> > > > Now, if a definition is resolved, and its parent
> > definition is a
> > > package, just outputs the fully-qualified name instead of walking
> > the full
> > > chain of member access
> > > > ---
> > > > .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> > > > debugger/.factorypath | 102
> > > +++++++++++++++++++++
> > > > 2 files changed, 111 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > index 741affb..cc0a892 100644
> > > > ---
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > +++
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > @@ -23,6 +23,7 @@ import
> > > org.apache.royale.compiler.codegen.ISubEmitter;
> > > > import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > > > import
> > org.apache.royale.compiler.constants.IASLanguageConstants;
> > > > import org.apache.royale.compiler.definitions.IDefinition;
> > > > +import
> > org.apache.royale.compiler.definitions.IPackageDefinition;
> > > > import
> > > org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > > > import
> > > org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > > > import
> > org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > > > @@ -32,7 +33,6 @@ import
> > >
> > org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > > > import
> > >
> > org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > > > import
> > >
> >
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > > > import
> > > org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > > > -import
> > >
> > org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> > > > import
> > > org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> > > > import
> > org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> > > > import org.apache.royale.compiler.internal.tree.as.*;
> > > > @@ -42,8 +42,6 @@ import
> org.apache.royale.compiler.tree.as.*;
> > > > import
> > > org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> > > > import org.apache.royale.compiler.utils.ASNodeUtils;
> > > >
> > > > -import javax.sound.midi.SysexMessage;
> > > > -
> > > > public class MemberAccessEmitter extends JSSubEmitter
> > implements
> > > > ISubEmitter<IMemberAccessExpressionNode>
> > > > {
> > > > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> > > JSSubEmitter implements
> > > > return;
> > > > }
> > > > }
> > > > + else if(def.getParent() instanceof
> > IPackageDefinition)
> > > > + {
> > > > + //this is a fully qualified name, and we
> > should
> > > output it directly
> > > > + //because we don't want it to be treated
> as
> > > dynamic access
> > > > +
> > > write(fjs.formatQualifiedName(def.getQualifiedName()));
> > > > + return;
> > > > + }
> > > > else if (def.getParent() != null &&
> > > >
> > > def.getParent().getQualifiedName().equals("Array"))
> > > > {
> > > > @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
> > > JSSubEmitter implements
> > > >
> > getEmitter().emitClosureEnd(leftNode,
> > > def);
> > > > }
> > > > return;
> > > > - }
> > > > + }
> > > > boolean isCustomNamespace = false;
> > > > if (def instanceof FunctionDefinition &&
> > node.getOperator()
> > > == OperatorType.MEMBER_ACCESS)
> > > > isCustomNamespace =
> > > fjs.isCustomNamespace((FunctionDefinition)def);
> > > > diff --git a/debugger/.factorypath b/debugger/.factorypath
> > > > new file mode 100644
> > > > index 0000000..2103813
> > > > --- /dev/null
> > > > +++ b/debugger/.factorypath
> > > > @@ -0,0 +1,102 @@
> > > > +<factorypath>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.
> > 201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > +</factorypath>
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C1466ad2654ad4c34bf6108d73547b02f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036454346349810&sdata=DVQNmmorvdrGC3%2FjZ3%2FBypmn28rYCmgJesIj91XoIHQ%3D&reserved=0
> > >
> > >
> > >
> >
> >
> >
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C1466ad2654ad4c34bf6108d73547b02f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036454346349810&sdata=JU9o7T7%2F330LMqyESFFr6fOSBxdFUyJDm%2FOebX0YI3U%3D&reserved=0
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Posted by Carlos Rovira <ca...@apache.org>.
Hi,
I notice all that files too from Eclips, can we remove all that files and
add all config files to .gitignore.
In doing that you ensure that your config files are the ones you use and
you don't get any other one from our repo.
I think we removed all other IDE files (VScode), specially the ones that
are tied to user paths.
Moonshine are as well in, but don't know right now if are tied to user
paths or not.
El lun., 9 sept. 2019 a las 18:04, Josh Tynjala (<jo...@bowlerhat.dev>)
escribió:
> Maybe. It's worth mentioning that VSCode's Java support is based on
> Eclipse, so it uses the same project file formats as Eclipse. We have
> .classpath and .project files committed in the repo, presumably to make it
> easy to import the compiler projects into Eclipse. However, they're
> constantly in a modified state in my local copy because VSCode overwrites
> them. I think that VSCode re-configures the project based on the Maven
> pom.xml file, but the repo's versions don't know about Maven.
>
> Even if we add .factorypath to .gitignore, both .classpath and .project are
> at risk of being accidentally committed too. It wouldn't really make a huge
> difference for me to ignore this file because I will still need to take
> extra care before committing. It just happened to slip through this time.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
> On Mon, Sep 9, 2019 at 8:27 AM Alex Harui <ah...@adobe.com.invalid>
> wrote:
>
> > Should it be added to .gitignore so it doesn't get committed?
> >
> > On 9/9/19, 6:58 AM, "Josh Tynjala" <jo...@bowlerhat.dev> wrote:
> >
> > I removed this file. Should be gone on both develop and release/
> 0.9.6.
> >
> > - Josh
> >
> >
> > On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <
> joshtynjala@bowlerhat.dev
> > >
> > wrote:
> >
> > > It's a project file created by VSCode. I didn't realize that I
> > > accidentally added it. It can be removed from the repo.
> > >
> > > - Josh
> > >
> > > On Saturday, September 7, 2019, Alex Harui
> <aharui@adobe.com.invalid
> > >
> > > wrote:
> > > > Josh,
> > > >
> > > > What is the .factorypath file? It is in the release package.
> > Should it
> > > even be in the repo?
> > > >
> > > > -Alex
> > > >
> > > > On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <
> > joshtynjala@apache.org>
> > > wrote:
> > > >
> > > > This is an automated email from the ASF dual-hosted git
> > repository.
> > > >
> > > > joshtynjala pushed a commit to branch develop
> > > > in repository
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726&sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3D&reserved=0
> > > >
> > > >
> > > > The following commit(s) were added to refs/heads/develop by
> > this
> > > push:
> > > > new f4f9898 MemberAccessEmitter: fixed issue where
> > > fully-qualified names were emitted as dynamic access with
> > > -js-dynamic-access-unknown-members=true
> > > > f4f9898 is described below
> > > >
> > > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > > Author: Josh Tynjala <jo...@apache.org>
> > > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > > >
> > > > MemberAccessEmitter: fixed issue where fully-qualified
> > names
> > > were emitted as dynamic access with
> > -js-dynamic-access-unknown-members=true
> > > >
> > > > Now, if a definition is resolved, and its parent
> > definition is a
> > > package, just outputs the fully-qualified name instead of walking
> > the full
> > > chain of member access
> > > > ---
> > > > .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> > > > debugger/.factorypath | 102
> > > +++++++++++++++++++++
> > > > 2 files changed, 111 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > index 741affb..cc0a892 100644
> > > > ---
> > >
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > +++
> > >
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > > @@ -23,6 +23,7 @@ import
> > > org.apache.royale.compiler.codegen.ISubEmitter;
> > > > import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > > > import
> > org.apache.royale.compiler.constants.IASLanguageConstants;
> > > > import org.apache.royale.compiler.definitions.IDefinition;
> > > > +import
> > org.apache.royale.compiler.definitions.IPackageDefinition;
> > > > import
> > > org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > > > import
> > > org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > > > import
> > org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > > > @@ -32,7 +33,6 @@ import
> > >
> > org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > > > import
> > >
> > org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > > > import
> > >
> >
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > > > import
> > > org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > > > -import
> > >
> > org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> > > > import
> > > org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> > > > import
> > org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> > > > import org.apache.royale.compiler.internal.tree.as.*;
> > > > @@ -42,8 +42,6 @@ import
> org.apache.royale.compiler.tree.as.*;
> > > > import
> > > org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> > > > import org.apache.royale.compiler.utils.ASNodeUtils;
> > > >
> > > > -import javax.sound.midi.SysexMessage;
> > > > -
> > > > public class MemberAccessEmitter extends JSSubEmitter
> > implements
> > > > ISubEmitter<IMemberAccessExpressionNode>
> > > > {
> > > > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> > > JSSubEmitter implements
> > > > return;
> > > > }
> > > > }
> > > > + else if(def.getParent() instanceof
> > IPackageDefinition)
> > > > + {
> > > > + //this is a fully qualified name, and we
> > should
> > > output it directly
> > > > + //because we don't want it to be treated
> as
> > > dynamic access
> > > > +
> > > write(fjs.formatQualifiedName(def.getQualifiedName()));
> > > > + return;
> > > > + }
> > > > else if (def.getParent() != null &&
> > > >
> > > def.getParent().getQualifiedName().equals("Array"))
> > > > {
> > > > @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
> > > JSSubEmitter implements
> > > >
> > getEmitter().emitClosureEnd(leftNode,
> > > def);
> > > > }
> > > > return;
> > > > - }
> > > > + }
> > > > boolean isCustomNamespace = false;
> > > > if (def instanceof FunctionDefinition &&
> > node.getOperator()
> > > == OperatorType.MEMBER_ACCESS)
> > > > isCustomNamespace =
> > > fjs.isCustomNamespace((FunctionDefinition)def);
> > > > diff --git a/debugger/.factorypath b/debugger/.factorypath
> > > > new file mode 100644
> > > > index 0000000..2103813
> > > > --- /dev/null
> > > > +++ b/debugger/.factorypath
> > > > @@ -0,0 +1,102 @@
> > > > +<factorypath>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.
> > 201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > > id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar"
> > enabled="true"
> > > runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> > id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > + <factorypathentry kind="VARJAR"
> > >
> >
> id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
> > > enabled="true" runInBatchMode="false"/>
> > > > +</factorypath>
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > > --
> > > Josh Tynjala
> > > Bowler Hat LLC <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817937723&sdata=0wrT5GMLOTAJvfNZ9SDrjywxaLcMOJQUe9PVLeu5NGM%3D&reserved=0
> > >
> > >
> > >
> >
> >
> >
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
Maybe. It's worth mentioning that VSCode's Java support is based on
Eclipse, so it uses the same project file formats as Eclipse. We have
.classpath and .project files committed in the repo, presumably to make it
easy to import the compiler projects into Eclipse. However, they're
constantly in a modified state in my local copy because VSCode overwrites
them. I think that VSCode re-configures the project based on the Maven
pom.xml file, but the repo's versions don't know about Maven.
Even if we add .factorypath to .gitignore, both .classpath and .project are
at risk of being accidentally committed too. It wouldn't really make a huge
difference for me to ignore this file because I will still need to take
extra care before committing. It just happened to slip through this time.
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
On Mon, Sep 9, 2019 at 8:27 AM Alex Harui <ah...@adobe.com.invalid> wrote:
> Should it be added to .gitignore so it doesn't get committed?
>
> On 9/9/19, 6:58 AM, "Josh Tynjala" <jo...@bowlerhat.dev> wrote:
>
> I removed this file. Should be gone on both develop and release/0.9.6.
>
> - Josh
>
>
> On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <joshtynjala@bowlerhat.dev
> >
> wrote:
>
> > It's a project file created by VSCode. I didn't realize that I
> > accidentally added it. It can be removed from the repo.
> >
> > - Josh
> >
> > On Saturday, September 7, 2019, Alex Harui <aharui@adobe.com.invalid
> >
> > wrote:
> > > Josh,
> > >
> > > What is the .factorypath file? It is in the release package.
> Should it
> > even be in the repo?
> > >
> > > -Alex
> > >
> > > On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <
> joshtynjala@apache.org>
> > wrote:
> > >
> > > This is an automated email from the ASF dual-hosted git
> repository.
> > >
> > > joshtynjala pushed a commit to branch develop
> > > in repository
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726&sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3D&reserved=0
> > >
> > >
> > > The following commit(s) were added to refs/heads/develop by
> this
> > push:
> > > new f4f9898 MemberAccessEmitter: fixed issue where
> > fully-qualified names were emitted as dynamic access with
> > -js-dynamic-access-unknown-members=true
> > > f4f9898 is described below
> > >
> > > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > > Author: Josh Tynjala <jo...@apache.org>
> > > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> > >
> > > MemberAccessEmitter: fixed issue where fully-qualified
> names
> > were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > >
> > > Now, if a definition is resolved, and its parent
> definition is a
> > package, just outputs the fully-qualified name instead of walking
> the full
> > chain of member access
> > > ---
> > > .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> > > debugger/.factorypath | 102
> > +++++++++++++++++++++
> > > 2 files changed, 111 insertions(+), 4 deletions(-)
> > >
> > > diff --git
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > index 741affb..cc0a892 100644
> > > ---
> >
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > +++
> >
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > > @@ -23,6 +23,7 @@ import
> > org.apache.royale.compiler.codegen.ISubEmitter;
> > > import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > > import
> org.apache.royale.compiler.constants.IASLanguageConstants;
> > > import org.apache.royale.compiler.definitions.IDefinition;
> > > +import
> org.apache.royale.compiler.definitions.IPackageDefinition;
> > > import
> > org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > > import
> > org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > > import
> org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > > @@ -32,7 +33,6 @@ import
> >
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > > import
> >
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > > import
> >
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > > import
> > org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > > -import
> >
> org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> > > import
> > org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> > > import
> org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> > > import org.apache.royale.compiler.internal.tree.as.*;
> > > @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> > > import
> > org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> > > import org.apache.royale.compiler.utils.ASNodeUtils;
> > >
> > > -import javax.sound.midi.SysexMessage;
> > > -
> > > public class MemberAccessEmitter extends JSSubEmitter
> implements
> > > ISubEmitter<IMemberAccessExpressionNode>
> > > {
> > > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> > JSSubEmitter implements
> > > return;
> > > }
> > > }
> > > + else if(def.getParent() instanceof
> IPackageDefinition)
> > > + {
> > > + //this is a fully qualified name, and we
> should
> > output it directly
> > > + //because we don't want it to be treated as
> > dynamic access
> > > +
> > write(fjs.formatQualifiedName(def.getQualifiedName()));
> > > + return;
> > > + }
> > > else if (def.getParent() != null &&
> > >
> > def.getParent().getQualifiedName().equals("Array"))
> > > {
> > > @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
> > JSSubEmitter implements
> > >
> getEmitter().emitClosureEnd(leftNode,
> > def);
> > > }
> > > return;
> > > - }
> > > + }
> > > boolean isCustomNamespace = false;
> > > if (def instanceof FunctionDefinition &&
> node.getOperator()
> > == OperatorType.MEMBER_ACCESS)
> > > isCustomNamespace =
> > fjs.isCustomNamespace((FunctionDefinition)def);
> > > diff --git a/debugger/.factorypath b/debugger/.factorypath
> > > new file mode 100644
> > > index 0000000..2103813
> > > --- /dev/null
> > > +++ b/debugger/.factorypath
> > > @@ -0,0 +1,102 @@
> > > +<factorypath>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.
> 201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> > id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar"
> enabled="true"
> > runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
> > enabled="true" runInBatchMode="false"/>
> > > + <factorypathentry kind="VARJAR"
> >
> id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
> > enabled="true" runInBatchMode="false"/>
> > > +</factorypath>
> > >
> > >
> > >
> > >
> >
> > --
> > --
> > Josh Tynjala
> > Bowler Hat LLC <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817937723&sdata=0wrT5GMLOTAJvfNZ9SDrjywxaLcMOJQUe9PVLeu5NGM%3D&reserved=0
> >
> >
> >
>
>
>
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Should it be added to .gitignore so it doesn't get committed?
On 9/9/19, 6:58 AM, "Josh Tynjala" <jo...@bowlerhat.dev> wrote:
I removed this file. Should be gone on both develop and release/0.9.6.
- Josh
On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <jo...@bowlerhat.dev>
wrote:
> It's a project file created by VSCode. I didn't realize that I
> accidentally added it. It can be removed from the repo.
>
> - Josh
>
> On Saturday, September 7, 2019, Alex Harui <ah...@adobe.com.invalid>
> wrote:
> > Josh,
> >
> > What is the .factorypath file? It is in the release package. Should it
> even be in the repo?
> >
> > -Alex
> >
> > On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <jo...@apache.org>
> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > joshtynjala pushed a commit to branch develop
> > in repository
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817927726&sdata=jLY5fG0O7mT1CeV%2B14Hzpzob4oAMW%2FclxdJB71Cfpl0%3D&reserved=0
> >
> >
> > The following commit(s) were added to refs/heads/develop by this
> push:
> > new f4f9898 MemberAccessEmitter: fixed issue where
> fully-qualified names were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > f4f9898 is described below
> >
> > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > Author: Josh Tynjala <jo...@apache.org>
> > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> >
> > MemberAccessEmitter: fixed issue where fully-qualified names
> were emitted as dynamic access with -js-dynamic-access-unknown-members=true
> >
> > Now, if a definition is resolved, and its parent definition is a
> package, just outputs the fully-qualified name instead of walking the full
> chain of member access
> > ---
> > .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> > debugger/.factorypath | 102
> +++++++++++++++++++++
> > 2 files changed, 111 insertions(+), 4 deletions(-)
> >
> > diff --git
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > index 741affb..cc0a892 100644
> > ---
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > +++
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > @@ -23,6 +23,7 @@ import
> org.apache.royale.compiler.codegen.ISubEmitter;
> > import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > import org.apache.royale.compiler.constants.IASLanguageConstants;
> > import org.apache.royale.compiler.definitions.IDefinition;
> > +import org.apache.royale.compiler.definitions.IPackageDefinition;
> > import
> org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > import
> org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > @@ -32,7 +33,6 @@ import
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > import
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > import
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > import
> org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > -import
> org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> > import
> org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> > import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> > import org.apache.royale.compiler.internal.tree.as.*;
> > @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> > import
> org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> > import org.apache.royale.compiler.utils.ASNodeUtils;
> >
> > -import javax.sound.midi.SysexMessage;
> > -
> > public class MemberAccessEmitter extends JSSubEmitter implements
> > ISubEmitter<IMemberAccessExpressionNode>
> > {
> > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > return;
> > }
> > }
> > + else if(def.getParent() instanceof IPackageDefinition)
> > + {
> > + //this is a fully qualified name, and we should
> output it directly
> > + //because we don't want it to be treated as
> dynamic access
> > +
> write(fjs.formatQualifiedName(def.getQualifiedName()));
> > + return;
> > + }
> > else if (def.getParent() != null &&
> >
> def.getParent().getQualifiedName().equals("Array"))
> > {
> > @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > getEmitter().emitClosureEnd(leftNode,
> def);
> > }
> > return;
> > - }
> > + }
> > boolean isCustomNamespace = false;
> > if (def instanceof FunctionDefinition && node.getOperator()
> == OperatorType.MEMBER_ACCESS)
> > isCustomNamespace =
> fjs.isCustomNamespace((FunctionDefinition)def);
> > diff --git a/debugger/.factorypath b/debugger/.factorypath
> > new file mode 100644
> > index 0000000..2103813
> > --- /dev/null
> > +++ b/debugger/.factorypath
> > @@ -0,0 +1,102 @@
> > +<factorypath>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
> enabled="true" runInBatchMode="false"/>
> > +</factorypath>
> >
> >
> >
> >
>
> --
> --
> Josh Tynjala
> Bowler Hat LLC <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C9d9cda8acf534faa637c08d7352db98f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637036342817937723&sdata=0wrT5GMLOTAJvfNZ9SDrjywxaLcMOJQUe9PVLeu5NGM%3D&reserved=0>
>
>
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
I removed this file. Should be gone on both develop and release/0.9.6.
- Josh
On Mon, Sep 9, 2019 at 6:39 AM Josh Tynjala <jo...@bowlerhat.dev>
wrote:
> It's a project file created by VSCode. I didn't realize that I
> accidentally added it. It can be removed from the repo.
>
> - Josh
>
> On Saturday, September 7, 2019, Alex Harui <ah...@adobe.com.invalid>
> wrote:
> > Josh,
> >
> > What is the .factorypath file? It is in the release package. Should it
> even be in the repo?
> >
> > -Alex
> >
> > On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <jo...@apache.org>
> wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > joshtynjala pushed a commit to branch develop
> > in repository
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C8f2fb400e5d54f73082808d71f50a99b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637012303647260983&sdata=W79nBsynNmvLQKY1tdcHgbR6K09oo%2FA%2F3z%2BRBb1Iq8E%3D&reserved=0
> >
> >
> > The following commit(s) were added to refs/heads/develop by this
> push:
> > new f4f9898 MemberAccessEmitter: fixed issue where
> fully-qualified names were emitted as dynamic access with
> -js-dynamic-access-unknown-members=true
> > f4f9898 is described below
> >
> > commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> > Author: Josh Tynjala <jo...@apache.org>
> > AuthorDate: Mon Aug 12 11:12:34 2019 -0700
> >
> > MemberAccessEmitter: fixed issue where fully-qualified names
> were emitted as dynamic access with -js-dynamic-access-unknown-members=true
> >
> > Now, if a definition is resolved, and its parent definition is a
> package, just outputs the fully-qualified name instead of walking the full
> chain of member access
> > ---
> > .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> > debugger/.factorypath | 102
> +++++++++++++++++++++
> > 2 files changed, 111 insertions(+), 4 deletions(-)
> >
> > diff --git
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > index 741affb..cc0a892 100644
> > ---
> a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > +++
> b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> > @@ -23,6 +23,7 @@ import
> org.apache.royale.compiler.codegen.ISubEmitter;
> > import org.apache.royale.compiler.codegen.js.IJSEmitter;
> > import org.apache.royale.compiler.constants.IASLanguageConstants;
> > import org.apache.royale.compiler.definitions.IDefinition;
> > +import org.apache.royale.compiler.definitions.IPackageDefinition;
> > import
> org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> > import
> org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> > import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> > @@ -32,7 +33,6 @@ import
> org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> > import
> org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> > import
> org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> > import
> org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> > -import
> org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> > import
> org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> > import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> > import org.apache.royale.compiler.internal.tree.as.*;
> > @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> > import
> org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> > import org.apache.royale.compiler.utils.ASNodeUtils;
> >
> > -import javax.sound.midi.SysexMessage;
> > -
> > public class MemberAccessEmitter extends JSSubEmitter implements
> > ISubEmitter<IMemberAccessExpressionNode>
> > {
> > @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > return;
> > }
> > }
> > + else if(def.getParent() instanceof IPackageDefinition)
> > + {
> > + //this is a fully qualified name, and we should
> output it directly
> > + //because we don't want it to be treated as
> dynamic access
> > +
> write(fjs.formatQualifiedName(def.getQualifiedName()));
> > + return;
> > + }
> > else if (def.getParent() != null &&
> >
> def.getParent().getQualifiedName().equals("Array"))
> > {
> > @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
> JSSubEmitter implements
> > getEmitter().emitClosureEnd(leftNode,
> def);
> > }
> > return;
> > - }
> > + }
> > boolean isCustomNamespace = false;
> > if (def instanceof FunctionDefinition && node.getOperator()
> == OperatorType.MEMBER_ACCESS)
> > isCustomNamespace =
> fjs.isCustomNamespace((FunctionDefinition)def);
> > diff --git a/debugger/.factorypath b/debugger/.factorypath
> > new file mode 100644
> > index 0000000..2103813
> > --- /dev/null
> > +++ b/debugger/.factorypath
> > @@ -0,0 +1,102 @@
> > +<factorypath>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar" enabled="true"
> runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
> enabled="true" runInBatchMode="false"/>
> > + <factorypathentry kind="VARJAR"
> id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
> enabled="true" runInBatchMode="false"/>
> > +</factorypath>
> >
> >
> >
> >
>
> --
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
>
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Posted by Josh Tynjala <jo...@bowlerhat.dev>.
It's a project file created by VSCode. I didn't realize that I accidentally
added it. It can be removed from the repo.
- Josh
On Saturday, September 7, 2019, Alex Harui <ah...@adobe.com.invalid> wrote:
> Josh,
>
> What is the .factorypath file? It is in the release package. Should it
even be in the repo?
>
> -Alex
>
> On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <jo...@apache.org>
wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> joshtynjala pushed a commit to branch develop
> in repository
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C8f2fb400e5d54f73082808d71f50a99b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637012303647260983&sdata=W79nBsynNmvLQKY1tdcHgbR6K09oo%2FA%2F3z%2BRBb1Iq8E%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new f4f9898 MemberAccessEmitter: fixed issue where
fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
> f4f9898 is described below
>
> commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
> Author: Josh Tynjala <jo...@apache.org>
> AuthorDate: Mon Aug 12 11:12:34 2019 -0700
>
> MemberAccessEmitter: fixed issue where fully-qualified names were
emitted as dynamic access with -js-dynamic-access-unknown-members=true
>
> Now, if a definition is resolved, and its parent definition is a
package, just outputs the fully-qualified name instead of walking the full
chain of member access
> ---
> .../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
> debugger/.factorypath | 102
+++++++++++++++++++++
> 2 files changed, 111 insertions(+), 4 deletions(-)
>
> diff --git
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> index 741affb..cc0a892 100644
> ---
a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> +++
b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
> @@ -23,6 +23,7 @@ import
org.apache.royale.compiler.codegen.ISubEmitter;
> import org.apache.royale.compiler.codegen.js.IJSEmitter;
> import org.apache.royale.compiler.constants.IASLanguageConstants;
> import org.apache.royale.compiler.definitions.IDefinition;
> +import org.apache.royale.compiler.definitions.IPackageDefinition;
> import
org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
> import
org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
> import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
> @@ -32,7 +33,6 @@ import
org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
> import
org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
> import
org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
> import
org.apache.royale.compiler.internal.definitions.AccessorDefinition;
> -import
org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
> import
org.apache.royale.compiler.internal.definitions.FunctionDefinition;
> import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
> import org.apache.royale.compiler.internal.tree.as.*;
> @@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
> import org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
> import org.apache.royale.compiler.utils.ASNodeUtils;
>
> -import javax.sound.midi.SysexMessage;
> -
> public class MemberAccessEmitter extends JSSubEmitter implements
> ISubEmitter<IMemberAccessExpressionNode>
> {
> @@ -177,6 +175,13 @@ public class MemberAccessEmitter extends
JSSubEmitter implements
> return;
> }
> }
> + else if(def.getParent() instanceof IPackageDefinition)
> + {
> + //this is a fully qualified name, and we should
output it directly
> + //because we don't want it to be treated as
dynamic access
> +
write(fjs.formatQualifiedName(def.getQualifiedName()));
> + return;
> + }
> else if (def.getParent() != null &&
>
def.getParent().getQualifiedName().equals("Array"))
> {
> @@ -260,7 +265,7 @@ public class MemberAccessEmitter extends
JSSubEmitter implements
> getEmitter().emitClosureEnd(leftNode,
def);
> }
> return;
> - }
> + }
> boolean isCustomNamespace = false;
> if (def instanceof FunctionDefinition && node.getOperator()
== OperatorType.MEMBER_ACCESS)
> isCustomNamespace =
fjs.isCustomNamespace((FunctionDefinition)def);
> diff --git a/debugger/.factorypath b/debugger/.factorypath
> new file mode 100644
> index 0000000..2103813
> --- /dev/null
> +++ b/debugger/.factorypath
> @@ -0,0 +1,102 @@
> +<factorypath>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar" enabled="true"
runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar"
enabled="true" runInBatchMode="false"/>
> + <factorypathentry kind="VARJAR"
id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar"
enabled="true" runInBatchMode="false"/>
> +</factorypath>
>
>
>
>
--
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
Re: [royale-compiler] branch develop updated: MemberAccessEmitter:
fixed issue where fully-qualified names were emitted as dynamic access with
-js-dynamic-access-unknown-members=true
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Josh,
What is the .factorypath file? It is in the release package. Should it even be in the repo?
-Alex
On 8/12/19, 11:12 AM, "joshtynjala@apache.org" <jo...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
joshtynjala pushed a commit to branch develop
in repository https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7C8f2fb400e5d54f73082808d71f50a99b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C637012303647260983&sdata=W79nBsynNmvLQKY1tdcHgbR6K09oo%2FA%2F3z%2BRBb1Iq8E%3D&reserved=0
The following commit(s) were added to refs/heads/develop by this push:
new f4f9898 MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
f4f9898 is described below
commit f4f9898ad6f94c903615db5bfae691bfaac4a5f3
Author: Josh Tynjala <jo...@apache.org>
AuthorDate: Mon Aug 12 11:12:34 2019 -0700
MemberAccessEmitter: fixed issue where fully-qualified names were emitted as dynamic access with -js-dynamic-access-unknown-members=true
Now, if a definition is resolved, and its parent definition is a package, just outputs the fully-qualified name instead of walking the full chain of member access
---
.../codegen/js/jx/MemberAccessEmitter.java | 13 ++-
debugger/.factorypath | 102 +++++++++++++++++++++
2 files changed, 111 insertions(+), 4 deletions(-)
diff --git a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
index 741affb..cc0a892 100644
--- a/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/royale/compiler/internal/codegen/js/jx/MemberAccessEmitter.java
@@ -23,6 +23,7 @@ import org.apache.royale.compiler.codegen.ISubEmitter;
import org.apache.royale.compiler.codegen.js.IJSEmitter;
import org.apache.royale.compiler.constants.IASLanguageConstants;
import org.apache.royale.compiler.definitions.IDefinition;
+import org.apache.royale.compiler.definitions.IPackageDefinition;
import org.apache.royale.compiler.internal.codegen.as.ASEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.JSEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.JSSubEmitter;
@@ -32,7 +33,6 @@ import org.apache.royale.compiler.internal.codegen.js.royale.JSRoyaleEmitterToke
import org.apache.royale.compiler.internal.codegen.js.goog.JSGoogEmitterTokens;
import org.apache.royale.compiler.internal.codegen.js.jx.BinaryOperatorEmitter.DatePropertiesGetters;
import org.apache.royale.compiler.internal.definitions.AccessorDefinition;
-import org.apache.royale.compiler.internal.definitions.AppliedVectorDefinition;
import org.apache.royale.compiler.internal.definitions.FunctionDefinition;
import org.apache.royale.compiler.internal.projects.RoyaleJSProject;
import org.apache.royale.compiler.internal.tree.as.*;
@@ -42,8 +42,6 @@ import org.apache.royale.compiler.tree.as.*;
import org.apache.royale.compiler.tree.as.IOperatorNode.OperatorType;
import org.apache.royale.compiler.utils.ASNodeUtils;
-import javax.sound.midi.SysexMessage;
-
public class MemberAccessEmitter extends JSSubEmitter implements
ISubEmitter<IMemberAccessExpressionNode>
{
@@ -177,6 +175,13 @@ public class MemberAccessEmitter extends JSSubEmitter implements
return;
}
}
+ else if(def.getParent() instanceof IPackageDefinition)
+ {
+ //this is a fully qualified name, and we should output it directly
+ //because we don't want it to be treated as dynamic access
+ write(fjs.formatQualifiedName(def.getQualifiedName()));
+ return;
+ }
else if (def.getParent() != null &&
def.getParent().getQualifiedName().equals("Array"))
{
@@ -260,7 +265,7 @@ public class MemberAccessEmitter extends JSSubEmitter implements
getEmitter().emitClosureEnd(leftNode, def);
}
return;
- }
+ }
boolean isCustomNamespace = false;
if (def instanceof FunctionDefinition && node.getOperator() == OperatorType.MEMBER_ACCESS)
isCustomNamespace = fjs.isCustomNamespace((FunctionDefinition)def);
diff --git a/debugger/.factorypath b/debugger/.factorypath
new file mode 100644
index 0000000..2103813
--- /dev/null
+++ b/debugger/.factorypath
@@ -0,0 +1,102 @@
+<factorypath>
+ <factorypathentry kind="VARJAR" id="M2_REPO/antlr/antlr/2.7.7/antlr-2.7.7.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/plugins/maven-scm-plugin/1.10.0/maven-scm-plugin-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-project/2.2.1/maven-project-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-profile/2.2.1/maven-profile-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-artifact-manager/2.2.1/maven-artifact-manager-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/wagon/wagon-provider-api/1.0-beta-6/wagon-provider-api-1.0-beta-6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/backport-util-concurrent/backport-util-concurrent/3.1/backport-util-concurrent-3.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-plugin-registry/2.2.1/maven-plugin-registry-2.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-container-default/1.0-alpha-9-stable-1/plexus-container-default-1.0-alpha-9-stable-1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/classworlds/classworlds/1.1-alpha-2/classworlds-1.1-alpha-2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-manager-plexus/1.10.0/maven-scm-manager-plexus-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-api/1.10.0/maven-scm-api-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-accurev/1.10.0/maven-scm-provider-accurev-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-bazaar/1.10.0/maven-scm-provider-bazaar-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-clearcase/1.10.0/maven-scm-provider-clearcase-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsexe/1.10.0/maven-scm-provider-cvsexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvs-commons/1.10.0/maven-scm-provider-cvs-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-cvsjava/1.10.0/maven-scm-provider-cvsjava-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/netbeans/lib/cvsclient/20060125/cvsclient-20060125.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/ch/ethz/ganymed/ganymed-ssh2/build210/ganymed-ssh2-build210.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-gitexe/1.10.0/maven-scm-provider-gitexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-git-commons/1.10.0/maven-scm-provider-git-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jgit/1.10.0/maven-scm-provider-jgit-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/jgit/org.eclipse.jgit/4.5.0.201609210915-r/org.eclipse.jgit-4.5.0.201609210915-r.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/jcraft/jsch/0.1.53/jsch-0.1.53.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/googlecode/javaewah/JavaEWAH/0.7.9/JavaEWAH-0.7.9.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/httpcomponents/httpclient/4.3.6/httpclient-4.3.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/httpcomponents/httpcore/4.3.3/httpcore-4.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-logging/commons-logging/1.1.3/commons-logging-1.1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-codec/commons-codec/1.6/commons-codec-1.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/slf4j/slf4j-api/1.7.2/slf4j-api-1.7.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-hg/1.10.0/maven-scm-provider-hg-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-perforce/1.10.0/maven-scm-provider-perforce-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-starteam/1.10.0/maven-scm-provider-starteam-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svnexe/1.10.0/maven-scm-provider-svnexe-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-synergy/1.10.0/maven-scm-provider-synergy-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-vss/1.10.0/maven-scm-provider-vss-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-tfs/1.10.0/maven-scm-provider-tfs-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-integrity/1.10.0/maven-scm-provider-integrity-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/mks/api/mksapi-jar/4.10.9049/mksapi-jar-4.10.9049.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/groovy/groovy-all/1.7.6/groovy-all-1.7.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-jazz/1.10.0/maven-scm-provider-jazz-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-local/1.10.0/maven-scm-provider-local-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/scm/maven-scm-provider-svn-commons/1.10.0/maven-scm-provider-svn-commons-1.10.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/plugins/maven-resources-plugin/3.1.0/maven-resources-plugin-3.1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-interpolation/1.24/plexus-interpolation-1.24.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/flex/flex-tool-api/1.0.0/flex-tool-api-1.0.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-io/commons-io/2.4/commons-io-2.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-cli/commons-cli/1.2/commons-cli-1.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/antlr/3.3/antlr-3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/antlr-runtime/3.3/antlr-runtime-3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/antlr/stringtemplate/3.2.1/stringtemplate-3.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/guava/guava/25.1-jre/guava-25.1-jre.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/checkerframework/checker-qual/2.0.0/checker-qual-2.0.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/errorprone/error_prone_annotations/2.1.3/error_prone_annotations-2.1.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/mojo/animal-sniffer-annotations/1.14/animal-sniffer-annotations-1.14.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/net/sourceforge/jburg/jburg/1.10.3/jburg-1.10.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/de/jflex/jflex/1.6.0/jflex-1.6.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/b1/pack/lzma-sdk-4j/9.22.0/lzma-sdk-4j-9.22.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/royale/compiler/swfutils/0.9.6-SNAPSHOT/swfutils-0.9.6-SNAPSHOT.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/commons-lang/commons-lang/2.6/commons-lang-2.6.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/args4j/args4j/2.0.28/args4j-2.0.28.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codeartisans/org.json/20131017/org.json-20131017.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/javascript/closure-compiler/v20151015/closure-compiler-v20151015.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/clojure/google-closure-library/0.0-20150902-b129bb9e/google-closure-library-0.0-20150902-b129bb9e.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/clojure/google-closure-library-third-party/0.0-20150902-b129bb9e/google-closure-library-third-party-0.0-20150902-b129bb9e.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-core/3.5.4/maven-core-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-model/3.5.4/maven-model-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-settings/3.5.4/maven-settings-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-settings-builder/3.5.4/maven-settings-builder-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-builder-support/3.5.4/maven-builder-support-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-repository-metadata/3.5.4/maven-repository-metadata-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-artifact/3.5.4/maven-artifact-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-model-builder/3.5.4/maven-model-builder-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-resolver-provider/3.5.4/maven-resolver-provider-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-impl/1.1.1/maven-resolver-impl-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-api/1.1.1/maven-resolver-api-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-spi/1.1.1/maven-resolver-spi-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/resolver/maven-resolver-util/1.1.1/maven-resolver-util-1.1.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.plexus/0.3.3/org.eclipse.sisu.plexus-0.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.3/org.eclipse.sisu.inject-0.3.3.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/com/google/inject/guice/4.2.0/guice-4.2.0-no_aop.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/aopalliance/aopalliance/1.0/aopalliance-1.0.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/javax/inject/javax.inject/1/javax.inject-1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-classworlds/2.5.2/plexus-classworlds-2.5.2.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/apache/maven/maven-plugin-api/3.5.4/maven-plugin-api-3.5.4.jar" enabled="true" runInBatchMode="false"/>
+ <factorypathentry kind="VARJAR" id="M2_REPO/org/codehaus/plexus/plexus-utils/3.0.3/plexus-utils-3.0.3.jar" enabled="true" runInBatchMode="false"/>
+</factorypath>