You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/01/25 22:58:54 UTC

[GitHub] [mynewt-core] jipanienko opened a new pull request #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0

jipanienko opened a new pull request #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0
URL: https://github.com/apache/mynewt-core/pull/2166
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] vrahane merged pull request #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0

Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0
URL: https://github.com/apache/mynewt-core/pull/2166
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0

Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on issue #2166: Fixes the SHELL_CMD_HELP_ definition when SHELL_CMD_HELP is 0
URL: https://github.com/apache/mynewt-core/pull/2166#issuecomment-578451139
 
 
   
   <!-- style-bot -->
   
   ## Style check summary
   
   #### sys/shell/include/shell/shell.h
   <details>
   
   ```diff
   @@ -95,20 +95,20 @@
     * @brief constructs a legacy shell command.
     */
    #define SHELL_CMD(cmd_, func_, help_) {         \
   -    .sc_ext = 0,                                \
   -    .sc_cmd_func = func_,                       \
   -    .sc_cmd = cmd_,                             \
   -    .help = SHELL_HELP_(help_),                 \
   +        .sc_ext = 0,                                \
   +        .sc_cmd_func = func_,                       \
   +        .sc_cmd = cmd_,                             \
   +        .help = SHELL_HELP_(help_),                 \
    }
    
    /**
     * @brief constructs an extended shell command.
     */
    #define SHELL_CMD_EXT(cmd_, func_, help_) {     \
   -    .sc_ext = 1,                                \
   -    .sc_cmd_ext_func = func_,                   \
   -    .sc_cmd = cmd_,                             \
   -    .help = SHELL_HELP_(help_),                 \
   +        .sc_ext = 1,                                \
   +        .sc_cmd_ext_func = func_,                   \
   +        .sc_cmd = cmd_,                             \
   +        .help = SHELL_HELP_(help_),                 \
    }
    
    /** @brief Register a shell_module object
   ```
   
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services