[GitHub] [daffodil] mbeckerle commented on a diff in pull request #919: Refactor to ensure each package is only in one jar (WIP)

["mbeckerle (via GitHub)" <gi...@apache.org>]

mbeckerle commented on code in PR #919:
URL: https://github.com/apache/daffodil/pull/919#discussion_r1084387360


##########
xsrc/test/scripts/refactor/fix-imports.scala:
##########
@@ -0,0 +1,184 @@
+import java.io.BufferedWriter
+import java.io.FileWriter
+import java.io.File
+import scala.collection.mutable.ListBuffer
+import scala.collection.mutable.Map
+import scala.io.Source
+
+object FixImports extends App {
+  val inline = true
+  val importMap = Map(
+    "daffodil-cli" -> "cli",
+    "daffodil-core" -> "core",
+    "daffodil-io" -> "io",
+    "daffodil-lib" -> "lib",
+    "daffodil-macro-lib" -> "lib",
+    "daffodil-runtime1" -> "runtime1",
+    "daffodil-runtime1-layers" -> "layers.runtime1",
+    "daffodil-runtime1-unparser" -> "unparsers.runtime1"

Review Comment:
   The implementation of layers is in daffodil-runtime1
   The predefined layers that come built-in to Daffodil are in daffodil-runtime1-layers. 
   
   So I would think daffodil-runtime1's layers should be the one that becomes layers.impl. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org