You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/12/03 03:13:38 UTC

Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Kevin Sweeney.


Bugs: AURORA-143 and AURORA-467
    https://issues.apache.org/jira/browse/AURORA-143
    https://issues.apache.org/jira/browse/AURORA-467


Repository: aurora


Description
-------

Remove getVersion RPC and DEPRECATEDversion Response field.


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 

Diff: https://reviews.apache.org/r/28623/diff/


Testing
-------


Thanks,

Bill Farner

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

Posted by Aurora ReviewBot <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63639
-----------------------------------------------------------

Ship it!


Master (8959b49) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28623/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-143 and AURORA-467
>     https://issues.apache.org/jira/browse/AURORA-143
>     https://issues.apache.org/jira/browse/AURORA-467
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove getVersion RPC and DEPRECATEDversion Response field.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 
> 
> Diff: https://reviews.apache.org/r/28623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

Posted by Kevin Sweeney <ke...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63754
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On Dec. 2, 2014, 6:13 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28623/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 6:13 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-143 and AURORA-467
>     https://issues.apache.org/jira/browse/AURORA-143
>     https://issues.apache.org/jira/browse/AURORA-467
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove getVersion RPC and DEPRECATEDversion Response field.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 
> 
> Diff: https://reviews.apache.org/r/28623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63714
-----------------------------------------------------------


David, Kevin - ping?

- Bill Farner


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28623/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-143 and AURORA-467
>     https://issues.apache.org/jira/browse/AURORA-143
>     https://issues.apache.org/jira/browse/AURORA-467
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove getVersion RPC and DEPRECATEDversion Response field.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 
> 
> Diff: https://reviews.apache.org/r/28623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

Posted by Maxim Khutornenko <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63638
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28623/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-143 and AURORA-467
>     https://issues.apache.org/jira/browse/AURORA-143
>     https://issues.apache.org/jira/browse/AURORA-467
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove getVersion RPC and DEPRECATEDversion Response field.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 
> 
> Diff: https://reviews.apache.org/r/28623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Re: Review Request 28623: Remove getVersion RPC and DEPRECATEDversion Response field.

Posted by David McLaughlin <da...@dmclaughlin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63783
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On Dec. 3, 2014, 2:13 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28623/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 2:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Kevin Sweeney.
> 
> 
> Bugs: AURORA-143 and AURORA-467
>     https://issues.apache.org/jira/browse/AURORA-143
>     https://issues.apache.org/jira/browse/AURORA-467
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove getVersion RPC and DEPRECATEDversion Response field.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6b63f04a7113527e26d7f38e877b0ebd07822108 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 0898c62315c5a47628ad629182c3177c86a00bce 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java 3406722067af40a91fe39340d94ee03d20d7ddbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d687f572b467a76e79d55ea1d7eb0abf7ec61bbd 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 04979084b5352d3044bd3c2ba7071e10d9992765 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java 840b3f88e7de306fa0af73593b5bac6cc00528da 
> 
> Diff: https://reviews.apache.org/r/28623/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>