You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/07 03:35:07 UTC

[GitHub] [doris] englefly opened a new pull request, #14003: [enhance](nereids) remove cast from numeric literal to decimal

englefly opened a new pull request, #14003:
URL: https://github.com/apache/doris/pull/14003

   # Proposed changes
   1. remove cast from numeric literal to decimal literal
   2. fix decimal scale bug: we will miss scale if first operand scale is smaller than the second operand scale. For example, 1.0 + l_quantity,  decimal(2,1) + decimal(15,2), we expect (15,2), not (15,1)
        
   Issue Number: close #xxx
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   4. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   5. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   6. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   7. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] englefly commented on pull request #14003: [enhance](nereids) remove cast from numeric literal to decimal

Posted by GitBox <gi...@apache.org>.
englefly commented on PR #14003:
URL: https://github.com/apache/doris/pull/14003#issuecomment-1305038673

   @morrySnow PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] hello-stephen commented on pull request #14003: [enhance](nereids) remove cast from numeric literal to decimal

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14003:
URL: https://github.com/apache/doris/pull/14003#issuecomment-1305069109

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 33.92 seconds
    load time: 465 seconds
    storage size: 17185418741 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221107043339_clickbench_pr_40799.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] englefly closed pull request #14003: [enhance](nereids) remove cast from numeric literal to decimal

Posted by GitBox <gi...@apache.org>.
englefly closed pull request #14003: [enhance](nereids) remove cast from numeric literal to decimal
URL: https://github.com/apache/doris/pull/14003


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org