You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2022/05/04 01:11:06 UTC
[james-project] 11/12: [PERF] Constant for Locales DEFAULT
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 41086d829186d304439b08e9f439546b4871d700
Author: Benoit TELLIER <bt...@linagora.com>
AuthorDate: Thu Apr 28 11:42:45 2022 +0700
[PERF] Constant for Locales DEFAULT
---
.../src/main/java/org/apache/james/imap/api/display/Locales.java | 3 +++
.../org/apache/james/imap/encode/ContinuationResponseEncoder.java | 3 +--
.../java/org/apache/james/imap/encode/StatusResponseEncoder.java | 7 +++----
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/display/Locales.java b/protocols/imap/src/main/java/org/apache/james/imap/api/display/Locales.java
index 5ce7c08189..c444966d43 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/api/display/Locales.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/api/display/Locales.java
@@ -22,6 +22,8 @@ package org.apache.james.imap.api.display;
import java.util.List;
import java.util.Locale;
+import com.google.common.collect.ImmutableList;
+
/**
* <p>
* Immutable bean describing localisation preferences.
@@ -36,6 +38,7 @@ import java.util.Locale;
* </ul>
*/
public class Locales {
+ public static Locales DEFAULT = new Locales(ImmutableList.of(), null);
private final List<Locale> userPreferences;
private final Locale clientPreference;
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/encode/ContinuationResponseEncoder.java b/protocols/imap/src/main/java/org/apache/james/imap/encode/ContinuationResponseEncoder.java
index e93bd30663..c46b891d15 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/encode/ContinuationResponseEncoder.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/encode/ContinuationResponseEncoder.java
@@ -20,7 +20,6 @@
package org.apache.james.imap.encode;
import java.io.IOException;
-import java.util.ArrayList;
import org.apache.james.imap.api.display.HumanReadableText;
import org.apache.james.imap.api.display.Locales;
@@ -48,6 +47,6 @@ public class ContinuationResponseEncoder implements ImapResponseEncoder<Continua
private String asString(HumanReadableText text) {
// TODO: calculate locales
- return localizer.localize(text, new Locales(new ArrayList<>(), null));
+ return localizer.localize(text, Locales.DEFAULT);
}
}
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/encode/StatusResponseEncoder.java b/protocols/imap/src/main/java/org/apache/james/imap/encode/StatusResponseEncoder.java
index 18dc09c76f..22273e2948 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/encode/StatusResponseEncoder.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/encode/StatusResponseEncoder.java
@@ -20,7 +20,6 @@
package org.apache.james.imap.encode;
import java.io.IOException;
-import java.util.ArrayList;
import java.util.Collection;
import org.apache.james.imap.api.ImapCommand;
@@ -48,7 +47,7 @@ public class StatusResponseEncoder implements ImapResponseEncoder<ImmutableStatu
@Override
public void encode(ImmutableStatusResponse response, ImapResponseComposer composer) throws IOException {
final Type serverResponseType = response.getServerResponseType();
- final byte[] type = asString(serverResponseType);
+ final byte[] type = asBytes(serverResponseType);
final ResponseCode responseCode = response.getResponseCode();
final String code = asString(responseCode);
final Tag tag = response.getTag();
@@ -105,7 +104,7 @@ public class StatusResponseEncoder implements ImapResponseEncoder<ImmutableStatu
private String asString(HumanReadableText text) {
// TODO: calculate locales
- return localizer.localize(text, new Locales(new ArrayList<>(), null));
+ return localizer.localize(text, Locales.DEFAULT);
}
private String asString(StatusResponse.ResponseCode code) {
@@ -116,7 +115,7 @@ public class StatusResponseEncoder implements ImapResponseEncoder<ImmutableStatu
}
}
- private byte[] asString(StatusResponse.Type type) {
+ private byte[] asBytes(StatusResponse.Type type) {
if (type == null) {
return null;
} else {
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org