You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/09/30 17:02:38 UTC
[GitHub] [lucene] thelabdude opened a new pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
thelabdude opened a new pull request #343:
URL: https://github.com/apache/lucene/pull/343
Manually fixing up some steps missed during the 8.10 release process.
I don't think this is correct because 8.10 is not listed in the `oldNames` array in `TestBackwardsCompatibility`. Somebody who understands how the `testAllVersionsTested` method is supposed to work on main (see comment about TRUNK in the code) needs to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] thelabdude merged pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #343:
URL: https://github.com/apache/lucene/pull/343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] madrob commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719652888
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -685,7 +686,7 @@ public void testAllVersionHaveCfsAndNocfs() {
}
public void testAllVersionsTested() throws Exception {
- Pattern constantPattern = Pattern.compile("LUCENE_(\\d+)_(\\d+)_(\\d+)(_ALPHA|_BETA)?");
+ Pattern constantPattern = Pattern.compile("LUCENE_(\\d+)_(\\d{1,2})_(\\d+)(_ALPHA|_BETA)?");
Review comment:
I don't think this is necessary.
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -383,6 +383,7 @@ public void testCreateEmptyIndex() throws Exception {
"sorted.8.0.0",
"sorted.8.1.0",
"sorted.8.1.1",
+ "sorted.8.10.0",
Review comment:
I think you also need an addition above to `oldNames`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] thelabdude commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719661346
##########
File path: lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
##########
@@ -383,6 +383,7 @@ public void testCreateEmptyIndex() throws Exception {
"sorted.8.0.0",
"sorted.8.1.0",
"sorted.8.1.1",
+ "sorted.8.10.0",
Review comment:
yes, that's the problem @madrob , see my comment in the PR description!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] madrob commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719728206
##########
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##########
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0 = new Version(8, 9, 0);
+ /**
+ * Match settings and bugs in Lucene's 8.10.0 release.
+ *
+ * @deprecated (8.11.0) Use latest
+ */
+ @Deprecated public static final Version LUCENE_8_10_0 = new Version(8, 10, 0);
Review comment:
I think you need to add an 8_11_0 version. A long time ago, when this all worked properly (like 8.2, I went spelunking in history) we would add the next minor immediately after a release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] thelabdude commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719739656
##########
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##########
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0 = new Version(8, 9, 0);
+ /**
+ * Match settings and bugs in Lucene's 8.10.0 release.
+ *
+ * @deprecated (8.11.0) Use latest
+ */
+ @Deprecated public static final Version LUCENE_8_10_0 = new Version(8, 10, 0);
Review comment:
It seems 8_11 is needed for main too, I don't know why after 8.9, it worked without an 8_10 but I'm already frustrated by this split repo and the release process being broken
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] janhoy commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719733791
##########
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##########
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0 = new Version(8, 9, 0);
+ /**
+ * Match settings and bugs in Lucene's 8.10.0 release.
+ *
+ * @deprecated (8.11.0) Use latest
+ */
+ @Deprecated public static final Version LUCENE_8_10_0 = new Version(8, 10, 0);
Review comment:
In main branch this looks good, with LUCENE_8_10_0 being added only. In branch_8x there would be a LUCENE_8_11_0, but that is [already OK](https://github.com/apache/lucene-solr/commit/08cdb36661957475359f815dda1e38915a6e331d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] thelabdude commented on a change in pull request #343: LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version
Posted by GitBox <gi...@apache.org>.
thelabdude commented on a change in pull request #343:
URL: https://github.com/apache/lucene/pull/343#discussion_r719780233
##########
File path: lucene/core/src/java/org/apache/lucene/util/Version.java
##########
@@ -168,6 +168,13 @@
*/
@Deprecated public static final Version LUCENE_8_9_0 = new Version(8, 9, 0);
+ /**
+ * Match settings and bugs in Lucene's 8.10.0 release.
+ *
+ * @deprecated (8.11.0) Use latest
+ */
+ @Deprecated public static final Version LUCENE_8_10_0 = new Version(8, 10, 0);
Review comment:
I added this JIRA to track improving the release manager so this doesn't happen again: https://issues.apache.org/jira/browse/LUCENE-10141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org