You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/06 08:14:52 UTC

[GitHub] [apisix-dashboard] forgaoqiang opened a new issue #1967: In route, both upstream and service can be set at the same time

forgaoqiang opened a new issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967


   ## Issue description
   In route config, both upstream and service<service has upstream too> can be set at the same time
   we have two paths:
   ```
   route -> upstream
   route -> service -> upstream
   ```
   At the same time, you can set an upstream to route and service at the same time, if I set an upstream to a route and associated a service<the service itself has an upstream> to the route, **which upstream will the route use**? 
   
   ## Expected behavior
   I think it should set upstream in service since we have a unique way to route a request
   `Request -> match route -> go through the plugins in the service -> upstream to DST service provider `
   
   ## How to Reproduce
   
   
   ## Screenshots
   
   
   ## Environment
   APISIX 2.6 with APISIX-dashboard 2.7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-876335255


   Ok,Let me have a look


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi edited a comment on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
guoqqqi edited a comment on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-877607421


   > @guoqqqi any update here?
   
   Yes, I found the problem in the latest version of the dashboard:
   When we select a service in the route page, clicking on the next page still configures the upstream.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-900587372


   Hi @forgaoqiang , did our answer solve your problem? If not, please update more details here, or we  consider this issue to be resolved after three days, thanks a lot~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-886233801


   > Yes I think so, when binding a Servcie with Route, it should be ok to skip Upstream Configure.
   
   Agree, refer to https://github.com/apache/apisix/blob/master/docs/en/latest/architecture-design/service.md
   
   actually when we associated a Route with a Service, we can also specify different plugin parameters or upstream for Route, at that time the Route parameter has a higher priority than Service. So it is ok for current dashboard IMO, when you want to use service upstream, just select `None` to skip the upstream page. 
   
   If we want to further optimize the user experience, we can make `None` as the default selection when select a service in the first step.
   
   ![image](https://user-images.githubusercontent.com/2561857/126907788-16e51403-e93a-41f1-9938-ac52bf567d53.png)
   
   Looking forward to your reply @forgaoqiang 
   
   cc @guoqqqi @juzhiyuan
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-877607421


   > @guoqqqi any update here?
   Yes, I found the problem in the latest version of the dashboard:
   When we select a service in the route page, clicking on the next page still configures the upstream.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-915049556


   close now, feel free to reopen it with any questions, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-877595668


   @guoqqqi any update here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-900587372


   Hi @forgaoqiang , did our answer solve your problem? If not, please update more details here, or we  consider this issue to be resolved after three days, thanks a lot~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] liuxiran closed issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
liuxiran closed issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] guoqqqi commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-877614983


   Our current version is
   - In the Route page, when selecting a service, you can select None to skip the Upstream page
   Do we need to update it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-877635016


   Yes I think so, when binding a Servcie with Route, it should be ok to skip Upstream Configure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1967: In route, both upstream and service can be set at the same time

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1967:
URL: https://github.com/apache/apisix-dashboard/issues/1967#issuecomment-875222964


   🤔 When we select a Service, it should hide the Upstream page, cc @guoqqqi to take a look when you have time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org