You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/07/02 23:17:50 UTC

[GitHub] [incubator-datasketches-java] leerho commented on a change in pull request #323: Small changes needed in master before the next set of PRs.

leerho commented on a change in pull request #323:
URL: https://github.com/apache/incubator-datasketches-java/pull/323#discussion_r449305775



##########
File path: src/test/java/org/apache/datasketches/tuple/aninteger/IntegerSketchTest.java
##########
@@ -82,7 +83,7 @@ public void aNotBTest() {
       a1Sk1.update(i, 1);
     }
     anotb.update(a1Sk1, a1Sk2);
-    CompactSketch<IntegerSummary> cSk = anotb.getResult();
+    anotb.getResult();

Review comment:
       I was just removing a dead assignment from the existing code.  You're right, I should of added an assertion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org