You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Ajay-singh1 (via GitHub)" <gi...@apache.org> on 2024/08/06 03:54:38 UTC
[PR] docs: fix broken links [apisix]
Ajay-singh1 opened a new pull request, #11480:
URL: https://github.com/apache/apisix/pull/11480
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
#11217
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270573109
@yzeng25 More work needs to be done their is no chinese versions of the page so we need to wait till that time.Closing this pull request as I don't know how can I link those pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 closed pull request #11480: docs: fix broken links
URL: https://github.com/apache/apisix/pull/11480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "yzeng25 (via GitHub)" <gi...@apache.org>.
yzeng25 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270476020
Hi @Ajay-singh1 your modifications in files `add-multiple-api-versions.md` and `manage-api-consumers.md` won't fix https://github.com/apache/apisix/issues/11217.
The current links work as expected, see [Manage API Consumers - More Tutorials](https://apisix.apache.org/docs/apisix/tutorials/manage-api-consumers/#more-tutorials) and [Add multiple API versions - Next steps](https://apisix.apache.org/docs/apisix/tutorials/add-multiple-api-versions/#next-steps).
As stated in #11217 , the page is `https://apisix.apache.org/zh/docs/apisix/tutorials/manage-api-consumers/` with `zh` in there. Since there is no zh-cn version of Manage API Consumers and Add multiple API versions pages, you can modify the links there and redirect to the en-us pages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270332263
@kayx23 I think we are good to go now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270479652
> Please change your modifications so that this pull request works as expected.
Yeah!Mistake thanks for the feedback I had mistakenly tried to rectify en docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270415473
I mean the hyperlink forwards to a 404 error page not found I think this should fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: fix broken links [apisix]
Posted by "Ajay-singh1 (via GitHub)" <gi...@apache.org>.
Ajay-singh1 commented on PR #11480:
URL: https://github.com/apache/apisix/pull/11480#issuecomment-2270418806
@pottekkat Can you kindly review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org