You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by jozefizso <gi...@git.apache.org> on 2016/03/11 21:51:27 UTC
[GitHub] lucenenet pull request: Fixed exception messages in NamedSPILoader...
GitHub user jozefizso opened a pull request:
https://github.com/apache/lucenenet/pull/162
Fixed exception messages in NamedSPILoader and Codec classes
NamedSPILoader and Codec classes used original Java based texts in exception messages that referenced JAR files and Java method names. This commit rewords these messages to be more .NET friendly.
It also fixes bug in the exception message in NamedSPILoader.Lookup() method that did not list the names of available services properly.
I refactored unit tests for the NamedSPILoader class to be more reliable. Original tests were moved to TestCodec class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jozefizso/lucenenet feature/spiloader_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #162
----
commit 7b8664729879f1a9d728f3db2eaad95e2f70e4a2
Author: Jozef Izso <jo...@gmail.com>
Date: 2016-03-11T10:53:08Z
Refactored NamedSPILoader and Codec class tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Fixed exception messages in NamedSPILoader...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: Fixed exception messages in NamedSPILoader...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/162#issuecomment-207031319
Looks good, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---