[GitHub] [jackrabbit-filevault] reschke commented on a diff in pull request #257: JCRVLT-666: improve performance of DefaultWorkspaceFilter.dumpCoverage (Session variant)

[GitBox <gi...@apache.org>]

reschke commented on code in PR #257:
URL: https://github.com/apache/jackrabbit-filevault/pull/257#discussion_r1032613650


##########
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/config/DefaultWorkspaceFilter.java:
##########
@@ -580,27 +581,49 @@ public void dumpCoverage(javax.jcr.Node rootNode, ProgressTrackerListener listen
     /**
      * {@inheritDoc}
      */
-    public void dumpCoverage(Session session, ProgressTrackerListener listener, boolean skipJcrContent)
-            throws RepositoryException {
+    public void dumpCoverage(Session session, ProgressTrackerListener listener, boolean skipJcrContent) throws RepositoryException {
         ProgressTracker tracker = new ProgressTracker(listener);
-        // get common ancestor
-        Tree<PathFilterSet> tree = new Tree<>();
-        for (PathFilterSet set: nodesFilterSets) {
-            tree.put(set.getRoot(), set);
-        }
-        String rootPath = tree.getRootPath();
-        javax.jcr.Node rootNode;
-        if (session.nodeExists(rootPath)) {
-            rootNode = session.getNode(rootPath);
-        } else if (session.nodeExists("/")) {
-            log.warn("Common ancestor {} not found. Using root node", rootPath);
-            rootNode = session.getRootNode();
-            rootPath = "/";
-        } else {
-            throw new PathNotFoundException("Common ancestor " + rootPath+ " not found.");
-        }
-        log.debug("Starting coverage dump at {} (skipJcrContent={})", rootPath, skipJcrContent);
-        dumpCoverage(rootNode, tracker, skipJcrContent);
+
+        List<javax.jcr.Node> nodes = new ArrayList<>();

Review Comment:
   leftover from refactoring; thanks for spotting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org