You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/15 11:36:25 UTC
[jira] [Commented] (TAJO-2108) Refactor Schema to be immutable

    [ https://issues.apache.org/jira/browse/TAJO-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242697#comment-15242697 ] 

ASF GitHub Bot commented on TAJO-2108:
--------------------------------------

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/1000

    TAJO-2108: Refactor Schema to be immutable.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-2108

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/1000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1000
    
----
commit 257c713bb58a438555d1a32e628a2033eec04f7b
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-01T10:46:34Z

    Add SchemaBuilder, FieldConverter, and TypeConverter.

commit eaf44335631a049197bc4237ea403976562e8726
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-01T10:48:48Z

    Move FieldConverter to o.a.tajo.catalog.

commit 074f133ad10decce0a716569897de0b596887e43
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-01T11:23:22Z

    Add SchemaFactory::builder()

commit f89e2ac9c096f2a13f51af4eef1e541fe4e952f9
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-02T03:08:04Z

    Fix some unit test failures.

commit 0738bd20c4f577592c8cee5a7a292466f7ac5798
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-04T02:47:15Z

    Remove addColumn from some unit tests, improve SchemaBuilder, TypeConverter, and FieldConverter.

commit d0a08fb56428b8ac4778bc4fa13baad5c5157123
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-04T03:08:53Z

    Remove Schema::addColumns(Schema).

commit d30ba3258f3f1b422ba4bc9feceba887ec174775
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-04T03:10:24Z

    Rename buildV1() to build().

commit 851562ca705aed5bcc876af328ef9496fa38fca7
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-04T06:41:28Z

    Remove addColumn from many unit tests.

commit e3b9d10c29b60132c86c736a7f1fa0160146fbc2
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-06T05:56:49Z

    Removed Schema::addColumn(String, DataType, int).

commit 19e63bfc143917e7ad704ae7b9a601e18d6ad8c3
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-07T07:26:55Z

    Fix many usages of Schema::addColumn.

commit 8639dacd1f7a9703fcb66eedc6f89f60e3679811
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-08T09:45:51Z

    Refactor SchemaBuilder for just list or set.

commit fe6c9b1a5cfa01caa22224da9fe5949aca92ef4a
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-10T06:51:34Z

    replace SchemaFactory to SchemaBuilder.

commit 4d3771051963045b5d02caaf7ed0ed31d5dc3975
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-12T02:41:25Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-2108

commit 9183adbc7cf5fd38c859bf81ae5bad310f7e07a9
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-12T04:43:42Z

    Add SchemaBuilder::addAll that takes map function.

commit 299527fb7535040e1ef4a62ae77e4bd54f4fc0e9
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-12T05:21:37Z

    Refactor many transforms to column.

commit 45100ced2c44e92eed1c24bc58a118e74f58d277
Author: Jihoon Son <ji...@apache.org>
Date:   2016-04-15T05:33:02Z

    TAJO-2119: Invalid sort result when sort key columns contain non-ascii values.
    
    Closes #998

commit a78ad890eb7ebe7096580799fe0dd05bb70a2618
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-15T09:34:30Z

    TAJO-2108: Refactor Schema to be immutable.
    
    Remove all addColumn.

commit 2cbcce334997566877eeb52b5e1a96ed58669daa
Author: Hyunsik Choi <hy...@apache.org>
Date:   2016-04-15T09:35:07Z

    Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-2108

----


> Refactor Schema to be immutable
> -------------------------------
>
>                 Key: TAJO-2108
>                 URL: https://issues.apache.org/jira/browse/TAJO-2108
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Catalog
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.12.0
>
>
> In order to make Schema to be simplified, we need to refactor it to be immutable object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)