You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/03/10 07:26:22 UTC
Review Request 57498: RANGER-1444:Do some code improvement in
security admin module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57498/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1444
https://issues.apache.org/jira/browse/RANGER-1444
Repository: ranger
Description
-------
1. There are some duplicate codes in method mapXXPortalUserToVXPortalUserForDefaultAccount.
{code}
userProfile.setLoginId(user.getLoginId());
userProfile.setEmailAddress(user.getEmailAddress());
userProfile.setStatus(user.getStatus());
userProfile.setUserRoleList(new ArrayList<String>());
userProfile.setId(user.getId());
userProfile.setFirstName(user.getFirstName());
userProfile.setLastName(user.getLastName());
userProfile.setPublicScreenName(user.getPublicScreenName());
userProfile.setEmailAddress(user.getEmailAddress());
{code}
We set the email address twice.
2. We have already checked if sess is null, so don't need to check it in below logic.
{code}
UserSessionBase sess = ContextUtil.getCurrentUserSession();
if (sess != null) {
if (sess != null && sess.isUserAdmin() || sess.isKeyAdmin()) {
return;
}
if (sess.getXXPortalUser().getId().equals(gjUser.getId())) {
return;
}
}
{code}
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 2740fac
Diff: https://reviews.apache.org/r/57498/diff/1/
Testing
-------
Thanks,
Qiang Zhang
Re: Review Request 57498: RANGER-1444:Do some code improvement in
security admin module
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57498/#review168617
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On March 10, 2017, 7:26 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57498/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 7:26 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1444
> https://issues.apache.org/jira/browse/RANGER-1444
>
>
> Repository: ranger
>
>
> Description
> -------
>
> 1. There are some duplicate codes in method mapXXPortalUserToVXPortalUserForDefaultAccount.
> {code}
> userProfile.setLoginId(user.getLoginId());
> userProfile.setEmailAddress(user.getEmailAddress());
> userProfile.setStatus(user.getStatus());
> userProfile.setUserRoleList(new ArrayList<String>());
> userProfile.setId(user.getId());
> userProfile.setFirstName(user.getFirstName());
> userProfile.setLastName(user.getLastName());
> userProfile.setPublicScreenName(user.getPublicScreenName());
> userProfile.setEmailAddress(user.getEmailAddress());
> {code}
> We set the email address twice.
> 2. We have already checked if sess is null, so don't need to check it in below logic.
> {code}
> UserSessionBase sess = ContextUtil.getCurrentUserSession();
> if (sess != null) {
> if (sess != null && sess.isUserAdmin() || sess.isKeyAdmin()) {
> return;
> }
> if (sess.getXXPortalUser().getId().equals(gjUser.getId())) {
> return;
> }
> }
> {code}
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 2740fac
>
>
> Diff: https://reviews.apache.org/r/57498/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qiang Zhang
>
>