You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 00:52:51 UTC
[GitHub] [spark] jiangxb1987 opened a new pull request #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
jiangxb1987 opened a new pull request #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007
### What changes were proposed in this pull request?
The test case has been flaky because the execution time sometimes exceeds the await duration. Increase the await duration to avoid flakiness.
### How was this patch tested?
Tested locally and it didn't fail anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603581249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25003/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603631411
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603631406
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603647844
Thanks @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603631411
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603580916
**[Test build #120293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120293/testReport)** for PR 28007 at commit [`bb4df54`](https://github.com/apache/spark/commit/bb4df549c96d961b80a5d07470417f6309d340a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603637402
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603581243
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603581249
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25003/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603638943
+1, LGTM. Thank you, @jiangxb1987 and @HyukjinKwon .
cc @holdenk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603581243
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603631406
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603630847
**[Test build #120293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120293/testReport)** for PR 28007 at commit [`bb4df54`](https://github.com/apache/spark/commit/bb4df549c96d961b80a5d07470417f6309d340a5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28007:
[SPARK-31239][CORE][TEST] Increase await duration in
`WorkerDecommissionSuite`.`verify a task with all workers decommissioned
succeeds`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28007: [SPARK-31239][CORE][TEST] Increase await duration in `WorkerDecommissionSuite`.`verify a task with all workers decommissioned succeeds`
URL: https://github.com/apache/spark/pull/28007#issuecomment-603580916
**[Test build #120293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120293/testReport)** for PR 28007 at commit [`bb4df54`](https://github.com/apache/spark/commit/bb4df549c96d961b80a5d07470417f6309d340a5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org