You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/22 19:07:43 UTC
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19685: [FFI] Add new containers and Implementations
leezu commented on a change in pull request #19685:
URL: https://github.com/apache/incubator-mxnet/pull/19685#discussion_r580516185
##########
File path: include/mxnet/runtime/packed_func.h
##########
@@ -497,6 +518,12 @@ class MXNetArgValue : public MXNetPODValue_ {
MXNET_CHECK_TYPE_CODE(type_code_, kStr);
return std::string(value_.v_str);
}
+ // } else if (type_code_ == kStr) {
+ // return std::string(value_.v_str);
+ // } else {
+ // CHECK(IsObjectRef<tvm::runtime::String>());
+ // return AsObjectRef<tvm::runtime::String>().operator std::string();
+ // }
Review comment:
Let's remove the unused code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org