You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/19 02:43:35 UTC
[GitHub] [superset] hoangminhquan-lhsdt opened a new pull request #18084: fix(histogram): display correct percentile value instead of formula
hoangminhquan-lhsdt opened a new pull request #18084:
URL: https://github.com/apache/superset/pull/18084
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR addresses issue #17550 regarding histogram percentile displaying the formula instead of the value. The long formula also causes the entire tooltip box to be long, which possibly leads to the entire tooltip being hidden to the side of the plot.
### BEFORE
<!--- Skip this if not applicable -->
### AFTER
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Open any histogram chart, "FCC 2018 Survey's Age distribution of respondents" is an included example.
- Hover the mouse pointer over any column to see the percentile value in the tooltip.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #17550
- [x] Required feature flags: Disables prettier linting in `superset-frontend/plugins/legacy-plugin-chart-histogram/src/Histogram.jsx` to prevent ERROR related to line length during `npm build`.
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #18084: fix(histogram): display correct percentile value instead of formula
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #18084:
URL: https://github.com/apache/superset/pull/18084#discussion_r802229186
##########
File path: superset-frontend/.prettierignore
##########
@@ -26,3 +26,4 @@ CHANGELOG.md
*-topo.json
temporary_superset_ui/
storybook-static/
+plugins/legacy-plugins-chart-histogram/src/Histogram.jsx
Review comment:
why is this necessary. Can you just run prettier or fix the error instead of ignoring this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18084: fix(histogram): display correct percentile value instead of formula
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18084:
URL: https://github.com/apache/superset/pull/18084#issuecomment-1033331447
# [Codecov](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18084](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da92ee8) into [master](https://codecov.io/gh/apache/superset/commit/8dea7f500bea194f55c15c9f1511a35b2c328cd6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8dea7f5) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head da92ee8 differs from pull request most recent head ab067bd. Consider uploading reports for the commit ab067bd to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18084 +/- ##
==========================================
- Coverage 66.36% 66.31% -0.05%
==========================================
Files 1570 1595 +25
Lines 61740 62596 +856
Branches 6241 6297 +56
==========================================
+ Hits 40972 41510 +538
- Misses 19170 19440 +270
- Partials 1598 1646 +48
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.33% <ø> (+0.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/examples/multi\_line.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlfbGluZS5weQ==) | `0.00% <0.00%> (-53.85%)` | :arrow_down: |
| [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | `0.00% <0.00%> (-39.33%)` | :arrow_down: |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `0.00% <0.00%> (-35.00%)` | :arrow_down: |
| [superset/examples/misc\_dashboard.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvbWlzY19kYXNoYm9hcmQucHk=) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [superset/examples/utils.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `0.00% <0.00%> (-28.58%)` | :arrow_down: |
| [superset/examples/tabbed\_dashboard.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvdGFiYmVkX2Rhc2hib2FyZC5weQ==) | `0.00% <0.00%> (-27.59%)` | :arrow_down: |
| [superset/db\_engine\_specs/teradata.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RlcmFkYXRhLnB5) | `62.75% <0.00%> (-27.25%)` | :arrow_down: |
| [superset/examples/bart\_lines.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmFydF9saW5lcy5weQ==) | `0.00% <0.00%> (-25.81%)` | :arrow_down: |
| [superset/utils/mock\_data.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbW9ja19kYXRhLnB5) | `0.00% <0.00%> (-25.19%)` | :arrow_down: |
| [superset/examples/paris.py](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | `0.00% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [213 more](https://codecov.io/gh/apache/superset/pull/18084/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8dea7f5...ab067bd](https://codecov.io/gh/apache/superset/pull/18084?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a change in pull request #18084: fix(histogram): display correct percentile value instead of formula
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #18084:
URL: https://github.com/apache/superset/pull/18084#discussion_r802229186
##########
File path: superset-frontend/.prettierignore
##########
@@ -26,3 +26,4 @@ CHANGELOG.md
*-topo.json
temporary_superset_ui/
storybook-static/
+plugins/legacy-plugins-chart-histogram/src/Histogram.jsx
Review comment:
why is this necessary? Can you just run prettier or fix the error instead of ignoring this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hoangminhquan-lhsdt commented on a change in pull request #18084: fix(histogram): display correct percentile value instead of formula
Posted by GitBox <gi...@apache.org>.
hoangminhquan-lhsdt commented on a change in pull request #18084:
URL: https://github.com/apache/superset/pull/18084#discussion_r802232298
##########
File path: superset-frontend/.prettierignore
##########
@@ -26,3 +26,4 @@ CHANGELOG.md
*-topo.json
temporary_superset_ui/
storybook-static/
+plugins/legacy-plugins-chart-histogram/src/Histogram.jsx
Review comment:
When I first ran Prettier on the file, it didn't change anything. I suspect it was because either I misconfigured Prettier on my local machine, or Prettier confused and couldn't reformat. I will try to configure it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai merged pull request #18084: fix(histogram): display correct percentile value instead of formula
Posted by GitBox <gi...@apache.org>.
nytai merged pull request #18084:
URL: https://github.com/apache/superset/pull/18084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org