[jira] [Commented] (BEAM-1882) Jdbc k8s scripts: switch pod -> replicaController

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956099#comment-15956099 ] 

ASF GitHub Bot commented on BEAM-1882:
--------------------------------------

GitHub user ssisk opened a pull request:

    https://github.com/apache/beam/pull/2431

    [BEAM-1882] Update postgres k8 scripts & add scripts for running local dev test

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    Currently, the postgres instance created is a pod - that means that if crashes/anything happens to it, it won't be re-created. We should should switch to ReplicaController, which will ensure that it will be automatically created again.
    
    This change:
    * consolidates the normal pod creation + service down to one file
    * switches from pods -> replica controllers
    * adds a k8s script that exposes a public IP - this can be used when doing local development.
    
    cc @jbonofre @jasonkuster 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ssisk/beam jdbc-it-k8-scripts

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2431.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2431
    
----
commit 01e00ccb8b4c7ab9c80fc2a4f2c0205b1af0d5bc
Author: Stephen Sisk <si...@google.com>
Date:   2017-03-17T22:09:00Z

    Update postgres k8 scripts & add scripts for running local dev test

----


> Jdbc k8s scripts: switch pod -> replicaController
> -------------------------------------------------
>
>                 Key: BEAM-1882
>                 URL: https://issues.apache.org/jira/browse/BEAM-1882
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-extensions
>            Reporter: Stephen Sisk
>            Assignee: Stephen Sisk
>
> Currently, the postgres instance created is a pod - that means that if crashes/anything happens to it, it won't be re-created. We should should switch to ReplicaController, which will ensure that it will be automatically created again.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)