[trafficserver] branch master updated: coverity 1385717: Out-of-bounds write

[bc...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bcall pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new ee62ed7  coverity 1385717: Out-of-bounds write
ee62ed7 is described below

commit ee62ed7cbfbcf0c5734d0d2bfc4750d086f52968
Author: Bryan Call <bc...@apache.org>
AuthorDate: Fri Feb 2 13:30:53 2018 -0800

    coverity 1385717: Out-of-bounds write
---
 proxy/http/HttpSM.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proxy/http/HttpSM.cc b/proxy/http/HttpSM.cc
index 07b3fbc..28d8be4 100644
--- a/proxy/http/HttpSM.cc
+++ b/proxy/http/HttpSM.cc
@@ -6938,7 +6938,7 @@ HttpSM::update_stats()
     int length                 = 0;
     const char *field          = t_state.hdr_info.client_request.value_get(MIME_FIELD_X_ID, MIME_LEN_X_ID, &length);
     if (field != nullptr && length > 0) {
-      length = std::min(length, static_cast<int>(sizeof(unique_id_string)));
+      length = std::min(length, static_cast<int>(sizeof(unique_id_string)) - 1);
       memcpy(unique_id_string, field, length);
       unique_id_string[length] = 0; // NULL terminate the string
     }

-- 
To stop receiving notification emails like this one, please contact
bcall@apache.org.