You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/07 22:57:31 UTC
[GitHub] [superset] justinpark opened a new pull request, #22050: chore(sqllab): Dimming status icon for running sql
justinpark opened a new pull request, #22050:
URL: https://github.com/apache/superset/pull/22050
### SUMMARY
There's [an open issue](https://github.com/apache/superset/issues/11123) that is hard to distinguish icons between running and successful query state in sqllab.
This commit adds the animated dimming translation for running statue to be distinguishing the running state easily.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- Before:
<img width="436" alt="Screen_Shot_2022-11-07_at_2_49_13_PM" src="https://user-images.githubusercontent.com/1392866/200432585-f763df31-a3e2-49ec-927b-e9ae26c64cde.png">
- After:
### TESTING INSTRUCTIONS
Go to sqllab
Run a query
### ADDITIONAL INFORMATION
- [x] Has associated issue: [issues#11123](https://github.com/apache/superset/issues/11123) [issues#13648](https://github.com/apache/superset/issues/13648)
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #22050: chore(sqllab): Change icon color for running sql
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1314655614
This is awesome @justinpark!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #22050: chore(sqllab): Dimming status icon for running sql
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1307708595
> Woot! I never realized that the icon changed. justinpark rather than flashing I was wondering whether a different color would be more intuitive, i.e.,
>
> 1. Grey: Not yet started
> 2. Blue: In progress*
> 3. Green: Success
> 4. Red: Failed
>
> Note people are red/green colorblind so maybe having a check-mark/x-mark inside the circle would help to distinguish between (3) and (4).
>
> * I think blue is likely better than orange as orange normally implies warning.
@john-bodley that's good idea. I updated the icons accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22050: chore(sqllab): Dimming status icon for running sql
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1306489067
# [Codecov](https://codecov.io/gh/apache/superset/pull/22050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22050](https://codecov.io/gh/apache/superset/pull/22050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8f1051) into [master](https://codecov.io/gh/apache/superset/commit/7a52b22237772be839a1871c3ecc9529e325fd03?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a52b22) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #22050 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1815 1815
Lines 69575 69578 +3
Branches 7486 7486
=======================================
+ Hits 46665 46668 +3
Misses 20974 20974
Partials 1936 1936
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.58% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/packages/superset-ui-core/src/style/index.tsx](https://codecov.io/gh/apache/superset/pull/22050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvc3R5bGUvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...tend/src/SqlLab/components/TabStatusIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/22050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYlN0YXR1c0ljb24vaW5kZXgudHN4) | `100.00% <100.00%> (ø)` | |
| [...aseModal/DatabaseConnectionForm/EncryptedField.tsx](https://codecov.io/gh/apache/superset/pull/22050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL0RhdGFiYXNlQ29ubmVjdGlvbkZvcm0vRW5jcnlwdGVkRmllbGQudHN4) | `10.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #22050: chore(sqllab): Change icon color for running sql
Posted by GitBox <gi...@apache.org>.
ktmud commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1315831936
Nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #22050: chore(sqllab): Change icon color for running sql
Posted by GitBox <gi...@apache.org>.
ktmud merged PR #22050:
URL: https://github.com/apache/superset/pull/22050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #22050: chore(sqllab): Dimming status icon for running sql
Posted by GitBox <gi...@apache.org>.
john-bodley commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1306588776
Woot! I never realized that the icon changed. Rather than flashing I was wondering whether a different color would be more intuitive, i.e.,
1. Grey: No previous query ran
2. Orange: Query running
3. Green: Query ran and was successful
4. Red: Query ran and failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #22050: chore(sqllab): Change icon color for running sql
Posted by GitBox <gi...@apache.org>.
justinpark commented on PR #22050:
URL: https://github.com/apache/superset/pull/22050#issuecomment-1314174790
cc: @michael-s-molina @eschutho
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org