You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yuseok89 (via GitHub)" <gi...@apache.org> on 2026/06/04 13:40:48 UTC
[PR] Reduce redundant Dag team lookups in authorization checks [airflow]
yuseok89 opened a new pull request, #68020:
URL: https://github.com/apache/airflow/pull/68020
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
closes: #61485
`requires_access_dag` resolves a Dag's owning team via `DagModel.get_team_name` on every call — **twice per grid endpoint** (`TASK_INSTANCE` + `RUN`) and on **every auto-refresh poll** — even though a Dag's team rarely changes.
This caches the lookup with a short per-process TTL.
### Impact
Team-ownership DB queries per grid page load:
| | first load | follow-up poll |
| ---------- | ---------: | -------------: |
| **before** | 6 | 6 |
| **after** | **1** | **0** |
### Also included
- New config `[core] team_name_cache_ttl` (default `30`s).
- Batches a per-Dag N+1 in the bulk dag-run authorization path.
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Opus 4.8
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce redundant Dag team lookups in authorization checks [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on PR #68020:
URL: https://github.com/apache/airflow/pull/68020#issuecomment-4625719121
> CI is failing
You're right, sorry. Once it was approved I moved it out of draft, but an approval isn't the same as a green CI, and I should have confirmed that first.
The failure wasn't in the tests this change adds. Caching the Dag team lookup shaves one query off the bulk task-instance delete path, which tripped a pre-existing query-count regression guard there. That's the cross-area interaction I didn't catch. It's now fixed and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce redundant Dag team lookups in authorization checks [airflow]
Posted by "yuseok89 (via GitHub)" <gi...@apache.org>.
yuseok89 commented on code in PR #68020:
URL: https://github.com/apache/airflow/pull/68020#discussion_r3358552858
##########
airflow-core/newsfragments/68020.improvement.rst:
##########
@@ -0,0 +1 @@
+Cache the per-request Dag team lookup used by authorization checks, avoiding redundant Team-table queries on the grid (and on its auto-refresh polls). The cache TTL is configurable via ``[core] team_name_cache_ttl`` (default ``30`` seconds).
Review Comment:
Done.
Removed it in the latest push. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce redundant Dag team lookups in authorization checks [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #68020:
URL: https://github.com/apache/airflow/pull/68020#issuecomment-4623695587
CI is failing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce redundant Dag team lookups in authorization checks [airflow]
Posted by "henry3260 (via GitHub)" <gi...@apache.org>.
henry3260 commented on code in PR #68020:
URL: https://github.com/apache/airflow/pull/68020#discussion_r3358046784
##########
airflow-core/newsfragments/68020.improvement.rst:
##########
@@ -0,0 +1 @@
+Cache the per-request Dag team lookup used by authorization checks, avoiding redundant Team-table queries on the grid (and on its auto-refresh polls). The cache TTL is configurable via ``[core] team_name_cache_ttl`` (default ``30`` seconds).
Review Comment:
Could we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Reduce redundant Dag team lookups in authorization checks [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #68020:
URL: https://github.com/apache/airflow/pull/68020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org