You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/12 08:57:27 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6252: arch/addrenv: Change text write enable/disable to generic mprot
pussuw opened a new pull request, #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252
Implement a generic access rights modification procedure instead
of the procedures that only do one thing (enable/disable write)
to one section (text).
## Summary
Follow up to https://github.com/apache/incubator-nuttx/pull/6193
## Impact
Minimal, implements the same thing with a different procedure
## Testing
icicle:knsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6252: arch/addrenv: Change text write enable/disable to generic mprot
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6252: arch/addrenv: Change text write enable/disable to generic mprot
Posted by GitBox <gi...@apache.org>.
pussuw commented on code in PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252#discussion_r871815417
##########
include/nuttx/arch.h:
##########
@@ -1186,41 +1186,25 @@ int up_addrenv_detach(FAR struct task_group_s *group, FAR struct tcb_s *tcb);
#endif
/****************************************************************************
- * Name: up_addrenv_text_enable_write
+ * Name: up_addrenv_mprot
*
* Description:
- * Temporarily enable write access to the .text section. This must be
- * called prior to loading the process code into memory.
+ * Modify access rights to an address range.
*
* Input Parameters:
* addrenv - The address environment to be modified.
+ * addr - Base address of the region.
+ * len - Size of the region.
+ * prot - Access right flags.
*
* Returned Value:
* Zero (OK) on success; a negated errno value on failure.
*
****************************************************************************/
#ifdef CONFIG_ARCH_ADDRENV
-int up_addrenv_text_enable_write(FAR group_addrenv_t *addrenv);
-#endif
-
-/****************************************************************************
- * Name: up_addrenv_text_disable_write
- *
- * Description:
- * Disable write access to the .text section. This must be called after the
- * process code is loaded into memory.
- *
- * Input Parameters:
- * addrenv - The address environment to be modified.
- *
- * Returned Value:
- * Zero (OK) on success; a negated errno value on failure.
- *
- ****************************************************************************/
-
-#ifdef CONFIG_ARCH_ADDRENV
-int up_addrenv_text_disable_write(FAR group_addrenv_t *addrenv);
+int up_addrenv_mprot(group_addrenv_t *addrenv, uintptr_t addr, size_t len,
Review Comment:
Yes need to fix. Goes to next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6252: arch/addrenv: Change text write enable/disable to generic mprot
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6252:
URL: https://github.com/apache/incubator-nuttx/pull/6252#discussion_r871810439
##########
include/nuttx/arch.h:
##########
@@ -1186,41 +1186,25 @@ int up_addrenv_detach(FAR struct task_group_s *group, FAR struct tcb_s *tcb);
#endif
/****************************************************************************
- * Name: up_addrenv_text_enable_write
+ * Name: up_addrenv_mprot
*
* Description:
- * Temporarily enable write access to the .text section. This must be
- * called prior to loading the process code into memory.
+ * Modify access rights to an address range.
*
* Input Parameters:
* addrenv - The address environment to be modified.
+ * addr - Base address of the region.
+ * len - Size of the region.
+ * prot - Access right flags.
*
* Returned Value:
* Zero (OK) on success; a negated errno value on failure.
*
****************************************************************************/
#ifdef CONFIG_ARCH_ADDRENV
-int up_addrenv_text_enable_write(FAR group_addrenv_t *addrenv);
-#endif
-
-/****************************************************************************
- * Name: up_addrenv_text_disable_write
- *
- * Description:
- * Disable write access to the .text section. This must be called after the
- * process code is loaded into memory.
- *
- * Input Parameters:
- * addrenv - The address environment to be modified.
- *
- * Returned Value:
- * Zero (OK) on success; a negated errno value on failure.
- *
- ****************************************************************************/
-
-#ifdef CONFIG_ARCH_ADDRENV
-int up_addrenv_text_disable_write(FAR group_addrenv_t *addrenv);
+int up_addrenv_mprot(group_addrenv_t *addrenv, uintptr_t addr, size_t len,
Review Comment:
Add `FAR` to `group_addrenv_t *addrenv`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org