[GitHub] [flink] leonardBang commented on a change in pull request #14787: [FLINK-21013][table-planner-blink] Ingest row time into StreamRecord in Blink planner

[GitBox <gi...@apache.org>]

leonardBang commented on a change in pull request #14787:
URL: https://github.com/apache/flink/pull/14787#discussion_r568541945



##########
File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLegacySink.java
##########
@@ -193,4 +199,18 @@ public CommonExecLegacySink(
                     inputTransform.getParallelism());
         }
     }
+
+    private int getRowtimeIndex(RowType inputRowType) {
+        int rowtimeIndex = -1;
+        final List<Integer> rowtimeFieldIndices = new ArrayList<>();
+        for (int i = 0; i < inputRowType.getFieldCount(); ++i) {
+            if (TypeCheckUtils.isRowTime(inputRowType.getTypeAt(i))) {
+                rowtimeFieldIndices.add(i);
+            }
+        }
+        if (rowtimeFieldIndices.size() == 1) {
+            rowtimeIndex = rowtimeFieldIndices.get(0);

Review comment:
       I think we can skip this just like other places deal the multiple fields with row time




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org