You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2020/05/26 11:37:37 UTC
svn commit: r1878116 - in
/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external:
basic/ impl/principal/
Author: angela
Date: Tue May 26 11:37:36 2020
New Revision: 1878116
URL: http://svn.apache.org/viewvc?rev=1878116&view=rev
Log:
OAK-9069 : Remove unnecessary (un)boxing in oak-auth-external (patch provided by Lars Grefer)
Modified:
jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java
jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalIdentityValidatorTest.java
jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ValidatorNoProtectionTest.java
Modified: jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java?rev=1878116&r1=1878115&r2=1878116&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java Tue May 26 11:37:36 2020
@@ -1232,7 +1232,7 @@ public class DefaultSyncContextTest exte
assertEquals(PropertyType.LONG, v.getType());
assertEquals(Long.MAX_VALUE, v.getLong());
- v = syncCtx.createValue(Integer.valueOf(23));
+ v = syncCtx.createValue(23);
assertNotNull(v);
assertEquals(PropertyType.LONG, v.getType());
assertEquals(23, v.getLong());
@@ -1250,7 +1250,7 @@ public class DefaultSyncContextTest exte
@Test
public void testCreateValueDouble() throws Exception {
- Value v = syncCtx.createValue(Double.valueOf(1.1));
+ Value v = syncCtx.createValue(1.1);
assertNotNull(v);
assertEquals(PropertyType.DOUBLE, v.getType());
assertEquals(1.1, v.getDouble(), 0);
Modified: jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalIdentityValidatorTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalIdentityValidatorTest.java?rev=1878116&r1=1878115&r2=1878116&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalIdentityValidatorTest.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalIdentityValidatorTest.java Tue May 26 11:37:36 2020
@@ -179,7 +179,7 @@ public class ExternalIdentityValidatorTe
java.util.Map<Type, Object> valMap = ImmutableMap.<Type, Object>of(
Type.BOOLEANS, ImmutableSet.of(Boolean.TRUE),
- Type.LONGS, ImmutableSet.of(new Long(1234)),
+ Type.LONGS, ImmutableSet.of(1234L),
Type.NAMES, ImmutableSet.of("id", "id2")
);
for (Type t : valMap.keySet()) {
@@ -252,7 +252,7 @@ public class ExternalIdentityValidatorTe
java.util.Map<Type, Object> valMap = ImmutableMap.<Type, Object>of(
Type.BOOLEAN, Boolean.TRUE,
- Type.LONG, new Long(1234),
+ Type.LONG, 1234L,
Type.NAME, "id"
);
for (Type t : valMap.keySet()) {
Modified: jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ValidatorNoProtectionTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ValidatorNoProtectionTest.java?rev=1878116&r1=1878115&r2=1878116&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ValidatorNoProtectionTest.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ValidatorNoProtectionTest.java Tue May 26 11:37:36 2020
@@ -54,7 +54,7 @@ public class ValidatorNoProtectionTest e
Map<Type, Object> valMap = ImmutableMap.<Type, Object>of(
Type.BOOLEAN, Boolean.TRUE,
- Type.LONG, new Long(1234),
+ Type.LONG, 1234L,
Type.NAME, "id"
);
for (Type t : valMap.keySet()) {