You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/24 05:48:10 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #4860: server: return domain path in login exception error message
shwstppr opened a new pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860
### Description
Minor fix to not show domain's DB ID in the error message that gets displayed in the UI.
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [x] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806101993
I'm not in favour of this, it would give extra information to a hacker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-805667200
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806388877
Closing this as not a major issue. Will revisit later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806072161
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806127757
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806117932
> let's not do this
Path is already there in domain field in the form and there are similar exception messages in the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-806071752
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-805670283
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4860 (SL-JID-61)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#issuecomment-805667789
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4860: server: return domain path in login exception error message
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4860:
URL: https://github.com/apache/cloudstack/pull/4860#discussion_r600408568
##########
File path: server/src/main/java/com/cloud/api/ApiServer.java
##########
@@ -1130,7 +1130,7 @@ public ResponseObject loginUser(final HttpSession session, final String username
return createLoginResponse(session);
}
- throw new CloudAuthenticationException("Failed to authenticate user " + username + " in domain " + domainId + "; please provide valid credentials");
+ throw new CloudAuthenticationException("Failed to authenticate user " + username + " in domain " + userDomain.getPath() + "; please provide valid credentials");
Review comment:
minor nit - General convention would be to override the `toString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org