[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on a change in pull request #24804: [SPARK-23472][CORE] Add defaultJavaOptions for driver and executor.
URL: https://github.com/apache/spark/pull/24804#discussion_r298999924
 
 

 ##########
 File path: docs/configuration.md
 ##########
 @@ -410,11 +410,31 @@ Apart from these, the following properties are also available, and may be useful
     your default properties file.
   </td>
 </tr>
+<tr>
+  <td><code>spark.driver.defaultJavaOptions</code></td>
+  <td>(none)</td>
+  <td>
+    A string of default JVM options to prepend to <code>spark.driver.extraJavaOptions</code>.
+    This is intended to be set by administrators.
+
+    For instance, GC settings or other logging.
+    Note that it is illegal to set maximum heap size (-Xmx) settings with this option. Maximum heap
+    size settings can be set with <code>spark.driver.memory</code> in the cluster mode and through
+    the <code>--driver-memory</code> command line option in the client mode.
+
+    <br /><em>Note:</em> In client mode, this config must not be set through the <code>SparkConf</code>
+    directly in your application, because the driver JVM has already started at that point.
+    Instead, please set this through the <code>--driver-java-options</code> command line option or in
+    your default properties file.
+  </td>
+</tr>
 <tr>
   <td><code>spark.driver.extraJavaOptions</code></td>
   <td>(none)</td>
   <td>
-    A string of extra JVM options to pass to the driver. For instance, GC settings or other logging.
+    A string of extra JVM options to pass to the driver. This is intended to be set by application developers.
 
 Review comment:
   Fixed both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org