You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/08/21 13:22:47 UTC

Review Request 71339: Refactored resource provider call validation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71339/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Bugs: MESOS-9482
    https://issues.apache.org/jira/browse/MESOS-9482


Repository: mesos


Description
-------

This patch collects validation of the presence of a resource provider ID
in a resource provider call into a single place.


Diffs
-----

  src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 


Diff: https://reviews.apache.org/r/71339/diff/1/


Testing
-------

`ninja check`


Thanks,

Benjamin Bannier


Re: Review Request 71339: Refactored resource provider call validation.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71339/#review217378
-----------------------------------------------------------


Ship it!




Ship It!

- Jan Schlicht


On Aug. 21, 2019, 3:22 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71339/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2019, 3:22 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Bugs: MESOS-9482
>     https://issues.apache.org/jira/browse/MESOS-9482
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch collects validation of the presence of a resource provider ID
> in a resource provider call into a single place.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/validation.cpp df55b5efe3543c1dfd8441997302ab76fdd4bcc1 
> 
> 
> Diff: https://reviews.apache.org/r/71339/diff/1/
> 
> 
> Testing
> -------
> 
> `ninja check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>