[jira] [Commented] (YETUS-219) pylint plugin displays grep error message if patch contains modification to python and other files

["Yetus QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045274#comment-15045274 ] 

Yetus QA commented on YETUS-219:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 1s {color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 1s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s {color} | {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 17s {color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/yetus:577e74f |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12776130/YETUS-219.00.patch |
| JIRA Issue | YETUS-219 |
| Optional Tests |  shellcheck  |
| uname | Linux e32720f01fb5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | nobuild |
| git revision | master / 0cfb58c |
| shellcheck | v0.4.1 |
| modules | C:  U:  |
| Powered by | Apache Yetus    http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-YETUS-Build/152/console |


This message was automatically generated.



> pylint plugin displays grep error message if patch contains modification to python and other files
> --------------------------------------------------------------------------------------------------
>
>                 Key: YETUS-219
>                 URL: https://issues.apache.org/jira/browse/YETUS-219
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Kengo Seki
>            Assignee: Marco Zühlke
>            Priority: Minor
>         Attachments: YETUS-219.00.patch
>
>
> I tried YETUS-211.1.patch and got the following error:
> {code}
> [sekikn@localhost yetus]$ precommit/test-patch.sh --build-tool=nobuild --plugins=all --resetrepo YETUS-211
> (snip)
> ============================================================================
> ============================================================================
>                           pylint plugin: prepatch
> ============================================================================
> ============================================================================
> Running pylint against modified python scripts.
> grep: /tmp/yetus-6656.30892/pylint.20253.7393: No such file or directory
> grep: /tmp/yetus-6656.30892/pylint.20253.7393: No such file or directory
> grep: /tmp/yetus-6656.30892/pylint.20253.7393: No such file or directory
> (snip)
> ============================================================================
> ============================================================================
>                          pylint plugin: postpatch
> ============================================================================
> ============================================================================
> Running pylint against modified python scripts.
> grep: /tmp/yetus-6656.30892/pylint.20253.31981: No such file or directory
> grep: /tmp/yetus-6656.30892/pylint.20253.31981: No such file or directory
> grep: /tmp/yetus-6656.30892/pylint.20253.31981: No such file or directory
> {code}
> This is because stderr redirected file is always checked even if it doesn't exist. Lines 135-141 should be inside of lines 130-134.
> {code:title=pylint.sh}
> 129   for i in ${CHANGED_FILES}; do
> 130     if [[ ${i} =~ \.py$ && -f ${i} ]]; then
> 131       # shellcheck disable=SC2086
> 132       eval "${PYLINT} ${PYLINT_OPTIONS} --msg-template='{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}' --reports=n ${i}" \
> 133         2>${PATCH_DIR}/${tmp} | ${AWK} '1<NR' >> "${PATCH_DIR}/patch-pylint-result.txt"
> 134     fi
> 135     # shellcheck disable=SC2016
> 136     count=$(${GREP} -v "^No config file found" "${PATCH_DIR}/${tmp}" | wc -l | ${AWK} '{print $1}')
> 137     if [[ ${count} -gt 0 ]]; then
> 138       add_vote_table -1 pylint "Something bad seems to have happened in running pylint. Please check pylint stderr files."
> 139       add_footer_table pylint "postpatch stderr: @@BASE@@/${tmp}"
> 140       return 1
> 141     fi
> 142   done
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)