[GitHub] [spark] maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #20965: [WIP][SPARK-21870][SQL] Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/20965#discussion_r319308567
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
 ##########
 @@ -824,59 +926,157 @@ case class HashAggregateExec(
     // generating input columns, we use `currentVars`.
     ctx.currentVars = new Array[ExprCode](aggregateBufferAttributes.length) ++ input
 
+    val aggNames = aggregateExpressions.map(_.aggregateFunction.prettyName)
+    // Computes buffer offsets for each aggregation function code
+    // in the underlying buffer row.
+    val bufferOffsets = {
 
 Review comment:
   yea, totally right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org