You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/03/30 00:46:46 UTC
Review Request 45456: Use correct query to serve /maintenance.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/
-----------------------------------------------------------
Review request for Aurora, John Sirois and Zameer Manji.
Bugs: AURORA-1652
https://issues.apache.org/jira/browse/AURORA-1652
Repository: aurora
Description
-------
Fixes the 2 issues identified in AURORA-1652.
I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
Diffs
-----
config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/45456/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126025
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On March 29, 2016, 3:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 3:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126146
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On March 29, 2016, 3:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 3:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126016
-----------------------------------------------------------
@ReviewBot retry
- Bill Farner
On March 29, 2016, 3:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 3:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126028
-----------------------------------------------------------
Master (ec29ac1) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7feb68a6cf90>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7feb68a6c290>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 663 passed, 5 skipped, 1 warnings in 208.34 seconds [0m
FAILURE
03:17:59 04:24 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 29, 2016, 10:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review125969
-----------------------------------------------------------
Master (ec29ac1) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7f11808d5938>(['./pants', '--pants-distdir=/tmp/user/10021/tmpbEcb4q', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7f11808d5938> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 162.95 seconds [0m
FAILURE
23:03:05 03:43 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 29, 2016, 10:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review125970
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On March 29, 2016, 4:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 4:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126154
-----------------------------------------------------------
Ship it!
Master (ec29ac1) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 29, 2016, 10:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126015
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 29, 2016, 3:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 3:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Bill Farner <wf...@apache.org>.
> On March 29, 2016, 7:56 p.m., Aurora ReviewBot wrote:
> > Master (ec29ac1) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [1m proxy_driver = ProxyDriver()[0m
> > [1m with temporary_dir() as checkpoint_root:[0m
> > [1m te = AuroraExecutor([0m
> > [1m> runner_provider=make_provider(checkpoint_root),[0m
> > [1m sandbox_provider=DefaultTestSandboxProvider())[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
> > [1m pex_location=thermos_runner_path(),[0m
> > _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> >
> > build = True
> >
> > [1m def thermos_runner_path(build=True):[0m
> > [1m if not build:[0m
> > [1m return getattr(thermos_runner_path, 'value', None)[0m
> > [1m [0m
> > [1m if not hasattr(thermos_runner_path, 'value'):[0m
> > [1m pex_dir = safe_mkdtemp()[0m
> > [1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
> > [1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
> > [1m[31mE assert 1 == 0[0m
> > [1m[31mE + where 1 = <function call at 0x7fd46cb95938>(['./pants', '--pants-distdir=/tmp/user/20000/tmpOXtyNI', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
> > [1m[31mE + where <function call at 0x7fd46cb95938> = subprocess.call[0m
> >
> > src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
> > -------------- Captured stderr call --------------
> > Traceback (most recent call last):
> > File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
> > from pants.bin.pants_exe import main
> > ImportError: No module named pants.bin.pants_exe
> > generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
> > [1m[31m 16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 156.66 seconds [0m
> >
> > FAILURE
> >
> >
> > 02:56:57 03:42 [complete][31m
> > FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Not sure what this indicates...trying a wipe of the jenkins workspace and rinse/repeat.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126020
-----------------------------------------------------------
On March 29, 2016, 3:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 3:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45456: Use correct query to serve /maintenance.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45456/#review126020
-----------------------------------------------------------
Master (ec29ac1) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7fd46cb95938>(['./pants', '--pants-distdir=/tmp/user/20000/tmpOXtyNI', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7fd46cb95938> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 640 passed, 5 skipped, 1 warnings, 8 error in 156.66 seconds [0m
FAILURE
02:56:57 03:42 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 29, 2016, 10:46 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45456/
> -----------------------------------------------------------
>
> (Updated March 29, 2016, 10:46 p.m.)
>
>
> Review request for Aurora, John Sirois and Zameer Manji.
>
>
> Bugs: AURORA-1652
> https://issues.apache.org/jira/browse/AURORA-1652
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixes the 2 issues identified in AURORA-1652.
>
> I will submit a separate patch to mitigate this issue by preventing error-prone calls to conveniences like `Query.slaveScoped()` with an empty `Iterable` (which has the effect of not filtering).
>
>
> Diffs
> -----
>
> config/legacy_untested_classes.txt afe954fa962b1590e9e6d0c44d62a0f923cb5727
> src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd
> src/test/java/org/apache/aurora/scheduler/http/MaintenanceTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/45456/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>