You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Alex Parvulescu (JIRA)" <ji...@apache.org> on 2012/06/22 19:24:42 UTC

[jira] [Created] (JCR-3357) Allow TimeSeries to track external counters

Alex Parvulescu created JCR-3357:
------------------------------------

             Summary: Allow TimeSeries to track external counters
                 Key: JCR-3357
                 URL: https://issues.apache.org/jira/browse/JCR-3357
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: jackrabbit-core
            Reporter: Alex Parvulescu
            Assignee: Alex Parvulescu


We should extend the current TimeSeries to be able to track external counters. 
This would facilitate the exposure of potentially already existing information by simply wrapping it into counters that will then be tracked by a normal TimeSeries and exposed as a repository statistic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JCR-3357) Allow TimeSeries to track external counters

Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Parvulescu updated JCR-3357:
---------------------------------

    Attachment: JCR-3357.patch

attached proposed patch.

I'm not 100% sure about the RepositoryStatisticsImpl#createDelegatingRecorder.
It checks for potential race condition, if somebody else created a recorder with the same name by calling #getOrCreateRecorder and updates to the good delegating recorder,
but it leaves the original caller with a potential stale counter reference.
I prefer stale counter that can be refreshed by calling #get again instead of a read-only 0 value counter.

feedback is welcome.

                
> Allow TimeSeries to track external counters
> -------------------------------------------
>
>                 Key: JCR-3357
>                 URL: https://issues.apache.org/jira/browse/JCR-3357
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3357.patch
>
>
> We should extend the current TimeSeries to be able to track external counters. 
> This would facilitate the exposure of potentially already existing information by simply wrapping it into counters that will then be tracked by a normal TimeSeries and exposed as a repository statistic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JCR-3357) Allow TimeSeries to track external counters

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405042#comment-13405042 ] 

Jukka Zitting commented on JCR-3357:
------------------------------------

The code looks reasonable to me, though it seems like we're already entering the territory of something that's beyond the scope of Jackrabbit.

Why do such external time series need to be exposed through the RepositoryStatistics mechanism? Instead of registering them with the repository, couldn't a deployment simply make such time series directly available to clients through JMX or some other management/monitoring interface?
                
> Allow TimeSeries to track external counters
> -------------------------------------------
>
>                 Key: JCR-3357
>                 URL: https://issues.apache.org/jira/browse/JCR-3357
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>         Attachments: JCR-3357.patch
>
>
> We should extend the current TimeSeries to be able to track external counters. 
> This would facilitate the exposure of potentially already existing information by simply wrapping it into counters that will then be tracked by a normal TimeSeries and exposed as a repository statistic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira