You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:06:25 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2378: hw/ipc_nrf5340: Add support for passing GPIO control
apache-mynewt-bot commented on pull request #2378:
URL: https://github.com/apache/mynewt-core/pull/2378#issuecomment-696175620
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c
<details>
```diff
@@ -159,7 +159,7 @@
#endif
/* Make sure network core if off when we set up IPC */
- NRF_RESET_S->NETWORK.FORCEOFF = RESET_NETWORK_FORCEOFF_FORCEOFF_Hold;
+ NRF_RESET_S->NETWORK.FORCEOFF = RESET_NETWORK_FORCEOFF_FORCEOFF_Hold;
memset(shms, 0, sizeof(shms));
#if MYNEWT_VAL(IPC_NRF5340_NET_GPIO)
@@ -167,7 +167,7 @@
for (i = 0; i < ARRAY_SIZE(gpios); i++) {
nrf_gpio = HAL_GPIO_PORT(gpios[i]);
nrf_gpio->PIN_CNF[HAL_GPIO_INDEX(gpios[i])] =
- GPIO_PIN_CNF_MCUSEL_NetworkMCU << GPIO_PIN_CNF_MCUSEL_Pos;
+ GPIO_PIN_CNF_MCUSEL_NetworkMCU << GPIO_PIN_CNF_MCUSEL_Pos;
}
#endif
#endif
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org