You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/06/04 00:13:00 UTC

[jira] [Work logged] (GOBBLIN-1458) Add endpoint to trigger a flow in GaaS

     [ https://issues.apache.org/jira/browse/GOBBLIN-1458?focusedWorklogId=606310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-606310 ]

ASF GitHub Bot logged work on GOBBLIN-1458:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/21 00:12
            Start Date: 04/Jun/21 00:12
    Worklog Time Spent: 10m 
      Work Description: jack-moseley opened a new pull request #3297:
URL: https://github.com/apache/gobblin/pull/3297


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1458
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   Previously the way to manually trigger an execution of a scheduled flow is to send a partial update that sets the flow's `runImmediately` property to true. This PR improves the API by adding a restli action that sends the same partial update. With this, flows can be triggered through the URL: `/flowconfigsV2/(flowGroup:test1,flowName:test1)?action=trigger`
   
   Also copied the implementation of `partialUpdateFlowConfig` to `FlowConfigV2ResourceLocalHandler` for testing convenience (normally when running the service `GobblinServiceFlowConfigResourceHandler` would be used, but for tests it is `FlowConfigV2ResourceLocalHandler`).
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Updated unit test and tested in local gaas
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 606310)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add endpoint to trigger a flow in GaaS
> --------------------------------------
>
>                 Key: GOBBLIN-1458
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1458
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)