[GitHub] [solr] madrob commented on a change in pull request #195: SOLR-15385 RawTypes Part IV, solr-core

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #195:
URL: https://github.com/apache/solr/pull/195#discussion_r659123757



##########
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##########
@@ -2627,8 +2626,7 @@ private static void ensureRegisteredSearcher(SolrCore core) throws InterruptedEx
         }
         registeredSearcher.decref();
       } else  {
-        @SuppressWarnings({"rawtypes"})
-        Future[] waitSearcher = new Future[1];
+        AtomicReference<Future<Void>> waitSearcher = new AtomicReference<>();

Review comment:
       We can do this, or we can do Array.newInstance and cast like I've done in other places, no strong opinions although I do lean towards the Reference solution because it feels like the intent is clearer to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org