You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/25 10:09:12 UTC
[GitHub] [spark] seayoun opened a new pull request #31645: [SPARK-34536]zstd-jni tag 1.3.2-2 lead read less shuffle data
seayoun opened a new pull request #31645:
URL: https://github.com/apache/spark/pull/31645
zstd-jni issues:
https://github.com/luben/zstd-jni/issues/159
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Change zstd-jni version to version 1.3.2-2
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
This old zstd-jni(tag 1.3.3-2) has probability to read less data when shuffle read.
The `ZstdInputStream` in zstd-jni(tag 1.3.3-2) maybe return 0 after a read function call, this doesn't meet the standard of `InputStream` and the `InputStream` will not return 0 unless len is 0; Spark will use a BufferedInputStream wrapped to ZstdInputStream, when ZstdInputStream read call return 0, BufferedInputStream will consider the 0 as the end of read and exit, this can lead data loss.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786029412
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135466/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785934234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785883196
cc @srowen as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786386384
> In the JIRA, I found the following, but the reason for the version choice is missing.
>
> > So, I think it's nessary to upgrade zstd-jni version to 1.4.4-3 in spark2.4 for spark2.4 has a wide use in production.
Another issue for ZstdInputStream. It happends in 1.4.4-3
https://github.com/luben/zstd-jni/issues/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31645: [SPARK-34536]zstd-jni tag 1.3.2-2 lead read less shuffle data
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785821132
cc @dongjoon-hyun FYI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31645: [SPARK-34536]zstd-jni tag 1.3.2-2 lead read less shuffle data
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785789507
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786011408
**[Test build #135466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135466/testReport)** for PR 31645 at commit [`03990d7`](https://github.com/apache/spark/commit/03990d7bf2290a389addc6004285959eec7974d4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786129880
Merged to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785875197
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785884417
> Usually, we don't upgrade dependencies in released branches. But this is a correctness bug and I think we can make an exception here.
@cloud-fan It's hard to add an exception here because it is imperceptible for spark, because spark use `BufferedInputStream` to deal with `ZstdInputStream` return 0, it's not in spark's core but the jdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786402676
Thanks, @seeyoun . You meant that another issue is fixed at 1.4.4-3, right? (Instead of `happens in 1.4.4-3`)
> Another issue for ZstdInputStream. It happends in 1.4.4-3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun edited a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun edited a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785884417
> Usually, we don't upgrade dependencies in released branches. But this is a correctness bug and I think we can make an exception here.
@cloud-fan It's hard to add an exception here because it is imperceptible for spark, spark use `BufferedInputStream` to deal with `ZstdInputStream` return 0, it's not in spark's code but the jdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun edited a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun edited a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785884417
> Usually, we don't upgrade dependencies in released branches. But this is a correctness bug and I think we can make an exception here.
@cloud-fan It's hard to add an exception here because it is imperceptible for spark, spark use `BufferedInputStream` to deal with `ZstdInputStream` return 0, it's not in spark's core but the jdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785918153
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785908602
**[Test build #135466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135466/testReport)** for PR 31645 at commit [`03990d7`](https://github.com/apache/spark/commit/03990d7bf2290a389addc6004285959eec7974d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785909578
Yeah this one is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785875027
Usually, we don't upgrade dependencies in released branches. But this is a correctness bug and I think we can make an exception here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31645:
URL: https://github.com/apache/spark/pull/31645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun edited a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun edited a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786386384
> In the JIRA, I found the following, but the reason for the version choice is missing.
>
> > So, I think it's nessary to upgrade zstd-jni version to 1.4.4-3 in spark2.4 for spark2.4 has a wide use in production.
Another issue for ZstdInputStream. It happends in 1.4.4-3
https://github.com/luben/zstd-jni/issues/110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786029864
It could be hard to reproduce zstd returning 0 bytes before EOF. If we can we'd mostly be testing what zstd tests already - the stream just never returns 0 bytes before done. If it's pretty hard to test, I think it's OK to merge without a specific test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785938343
In the JIRA, I found the following, but the reason for the version choice is missing.
> So, I think it's nessary to upgrade zstd-jni version to 1.4.4-3 in spark2.4 for spark2.4 has a wide use in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785789507
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-786029412
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135466/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785907816
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun commented on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun commented on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785882869
> Can you also run `./dev/test-dependencies.sh --replace-manifest`?
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785908602
**[Test build #135466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135466/testReport)** for PR 31645 at commit [`03990d7`](https://github.com/apache/spark/commit/03990d7bf2290a389addc6004285959eec7974d4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785934234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40047/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] seayoun removed a comment on pull request #31645: [SPARK-30228][BUILD][2.4] Update zstd-jni to 1.4.4-3
Posted by GitBox <gi...@apache.org>.
seayoun removed a comment on pull request #31645:
URL: https://github.com/apache/spark/pull/31645#issuecomment-785884417
> Usually, we don't upgrade dependencies in released branches. But this is a correctness bug and I think we can make an exception here.
@cloud-fan It's hard to add an exception here because it is imperceptible for spark, spark use `BufferedInputStream` to deal with `ZstdInputStream` return 0, it's not in spark's code but the jdk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org