[GitHub] [spark] cloud-fan commented on a diff in pull request #37357: [SPARK-39933][SQL][TESTS] Check query context by `checkError()`

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #37357:
URL: https://github.com/apache/spark/pull/37357#discussion_r934672161


##########
core/src/test/scala/org/apache/spark/SparkFunSuite.scala:
##########
@@ -318,6 +319,15 @@ abstract class SparkFunSuite
     } else {
       assert(expectedParameters === parameters)
     }
+    val actualQueryContext = exception.getQueryContext()
+    assert(actualQueryContext.length === queryContext.length, "Invalid length of the query context")
+    actualQueryContext.zip(queryContext).foreach { case (actual, expected) =>

Review Comment:
   shall we implement the `equalTo` method in the `QueryContext` implementation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org