You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com> on 2016/03/29 00:59:05 UTC
Review Request 45406: HIVE-13349: Metastore Changes : HS2 changes :
API calls for retrieving primary keys and foreign keys information
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
Metastore Changes : HS2 changes : API calls for retrieving primary keys and foreign keys information
Diffs
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 8a8f8b1
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 6e5de20
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 3e7c6e7
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 97c07a5
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 2695ffa
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java bb6e584
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java 083d340
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java 9004457
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java bfd1206
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java 657bb7b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java ba059fe
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 2769845
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java adef415
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java de588e2
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java 6b08234
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeyRel.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java 5f8ce0d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java f88e279
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java 0236b4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java 89eb819
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java 2408ad1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java 8946635
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java 629c042
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java 9f57a4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleResponse.java 02c652a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalResponse.java c013e0e
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java b00fb9c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java d7dd8ec
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java 44d99c7
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java 488d3a0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java f39f582
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java fcbbd18
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java e11a2b3
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java a247221
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e8232b9
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 2c41912
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java f0c5ce1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 12ae66d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 8416369
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 2e903f1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java e1792bd
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java bba2d40
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java ab151b1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 7f8a044
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 75d0ebb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java d5a8d99
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6e334f6
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java afa832c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java b9b7f3c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java c32f50c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 938f06b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java d0daee5
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 78d4250
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 13e30db
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 14cd42e
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 05a0749
metastore/src/gen/thrift/gen-php/metastore/Types.php 488a920
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 516b926
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py ac8d8a4
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 10eaf4a
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1cf40ae
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e782bb5
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 35adb39
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/model/org/apache/hadoop/hive/metastore/model/MForeignKeyRel.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MPKFKMapping.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf
metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
> On April 4, 2016, 11:11 p.m., Ashutosh Chauhan wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java, line 2601
> > <https://reviews.apache.org/r/45406/diff/2/?file=1324927#file1324927line2601>
> >
> > We need to implement these methods.
Will do in a followup jira
- Hari Sankar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review126950
-----------------------------------------------------------
On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:47 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review126950
-----------------------------------------------------------
metastore/if/hive_metastore.thrift (line 53)
<https://reviews.apache.org/r/45406/#comment190033>
We don't use term schema that much in Hive. So, its better to call it db
metastore/if/hive_metastore.thrift (line 61)
<https://reviews.apache.org/r/45406/#comment190034>
Similar comment to use db instead of schema.
metastore/if/hive_metastore.thrift (line 302)
<https://reviews.apache.org/r/45406/#comment190036>
its better to mark new fields as optional param for better compat.
metastore/if/hive_metastore.thrift (line 1215)
<https://reviews.apache.org/r/45406/#comment190037>
We should follow request/response pattern for these api design. e.g, get_aggr_stats_for()
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (lines 4 - 6)
<https://reviews.apache.org/r/45406/#comment190078>
Instead of storing name, type and comment. We should just only store CS_ID with not null constraint here.
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 7)
<https://reviews.apache.org/r/45406/#comment190079>
We also need to store constraint name.
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 8)
<https://reviews.apache.org/r/45406/#comment190080>
Also, it will be good to add index for this table on CS_ID
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 13)
<https://reviews.apache.org/r/45406/#comment190082>
There should be an index on this table on constraint_name.
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql (line 21)
<https://reviews.apache.org/r/45406/#comment190083>
Index on constraint name.
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java (lines 1819 - 1821)
<https://reviews.apache.org/r/45406/#comment190084>
These joins could be expensive.
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java (line 2601)
<https://reviews.apache.org/r/45406/#comment190085>
We need to implement these methods.
metastore/src/model/package.jdo (line 151)
<https://reviews.apache.org/r/45406/#comment190086>
Its better to store PKeys in COLUMNS_V2 and thus we can avoid a join.
- Ashutosh Chauhan
On April 4, 2016, 8:45 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:45 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
> metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf
> metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542
> metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
> On April 11, 2016, 11:23 p.m., Ashutosh Chauhan wrote:
> > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql, line 2
> > <https://reviews.apache.org/r/45406/diff/3/?file=1339577#file1339577line2>
> >
> > Any reason for index on constraint name, position?
> > I think on CD_ID it makes more sense.
This is required for disallowing duplicate constraint names. Also, index is created on parent table id.
> On April 11, 2016, 11:23 p.m., Ashutosh Chauhan wrote:
> > metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql, line 1
> > <https://reviews.apache.org/r/45406/diff/3/?file=1339577#file1339577line1>
> >
> > Do you need TBL_ID?
> > Since you need a join with TBLS anyway and CD_ID is unique, I don't think its useful to store TBL_ID here.
Without TBL_ID, a join with SDS is required on SD_ID to retrieve all the columns associated with a table.
- Hari Sankar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review128275
-----------------------------------------------------------
On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:47 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review128275
-----------------------------------------------------------
metastore/if/hive_metastore.thrift (line 1209)
<https://reviews.apache.org/r/45406/#comment191702>
I am not sure if this is needed.
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql (line 1)
<https://reviews.apache.org/r/45406/#comment191710>
Do you need TBL_ID?
Since you need a join with TBLS anyway and CD_ID is unique, I don't think its useful to store TBL_ID here.
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql (line 2)
<https://reviews.apache.org/r/45406/#comment191713>
Any reason for index on constraint name, position?
I think on CD_ID it makes more sense.
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql (line 996)
<https://reviews.apache.org/r/45406/#comment191714>
Its better to just inline those statements.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6141)
<https://reviews.apache.org/r/45406/#comment191715>
I don't think there is need for this.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6170)
<https://reviews.apache.org/r/45406/#comment191716>
No need for this.
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 6173)
<https://reviews.apache.org/r/45406/#comment191717>
Neither for this.
- Ashutosh Chauhan
On April 11, 2016, 5:45 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 5:45 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
> service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote 9a2322f
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review129030
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java (line 3267)
<https://reviews.apache.org/r/45406/#comment192495>
Instead of making this check, we should just try to persist the row in constraint table, it will fail in case there is a duplicate name, since its a part of primary key, in which case we pick another name.
metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java (line 7)
<https://reviews.apache.org/r/45406/#comment192496>
I don't see this class getting used anywhere. In jdo mapping its seems you are using inner class PK which is defined in MConstraint. Do we need both?
- Ashutosh Chauhan
On April 14, 2016, 10:44 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 10:44 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysRequest.java PRE-CREATION
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java PRE-CREATION
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java PRE-CREATION
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java PRE-CREATION
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLForeignKey.java PRE-CREATION
> metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLPrimaryKey.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java PRE-CREATION
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated April 14, 2016, 10:44 p.m.)
Review request for hive and Ashutosh Chauhan.
Changes
-------
1. Added enable/validate/rely bits to the metastore.
2. Validate fk name, pk names check for duplicates.
3. Generate constraint names if the user does not provide one.
Repository: hive-git
Description
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysRequest.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeysResponse.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysRequest.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrimaryKeysResponse.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLForeignKey.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SQLPrimaryKey.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraintPK.java PRE-CREATION
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated April 13, 2016, 7:59 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
> On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote:
> > In hive-schema-2.1-***.sql instead of adding run <script-name> you may just inline new create table statements which is consistent with other create table statements there.
Ok makes sense. Will do it in the new upload.
> On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote:
> > metastore/if/hive_metastore.thrift, lines 62-63
> > <https://reviews.apache.org/r/45406/diff/4/?file=1341804#file1341804line62>
> >
> > fk_constraint_name, pk_constraint_name ?
The naming convention is based on https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys(java.lang.String,%20java.lang.String,%20java.lang.String).
> On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote:
> > metastore/if/hive_metastore.thrift, line 49
> > <https://reviews.apache.org/r/45406/diff/4/?file=1341804#file1341804line49>
> >
> > should this be called constraint name ?
https://docs.oracle.com/javase/7/docs/api/java/sql/DatabaseMetaData.html#getPrimaryKeys(java.lang.String,%20java.lang.String,%20java.lang.String) is the naming standard followed
> On April 13, 2016, 3:12 p.m., Ashutosh Chauhan wrote:
> > metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql, line 1
> > <https://reviews.apache.org/r/45406/diff/4/?file=1341808#file1341808line1>
> >
> > IF NOT Exists missing
Create table without an IF NOT EXISTS is in convention with the create statements in the *mssql.sql files. I added "IF EXISTS" on oracle/postgres scripts based on the comments. But in hindsight, it is not necessary/rather may be a bad approach to add the IF NOT Exists clause since we should throw error if the table already exists and not silently ignore the create statement which can cause issue if the already existing table definition is not the same as the one expected by hive.
- Hari Sankar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review128681
-----------------------------------------------------------
On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:47 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/#review128681
-----------------------------------------------------------
In hive-schema-2.1-***.sql instead of adding run <script-name> you may just inline new create table statements which is consistent with other create table statements there.
metastore/if/hive_metastore.thrift (line 49)
<https://reviews.apache.org/r/45406/#comment192159>
should this be called constraint name ?
metastore/if/hive_metastore.thrift (lines 60 - 61)
<https://reviews.apache.org/r/45406/#comment192162>
Where is this info store in backend?
metastore/if/hive_metastore.thrift (lines 62 - 63)
<https://reviews.apache.org/r/45406/#comment192161>
fk_constraint_name, pk_constraint_name ?
metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql (line 1)
<https://reviews.apache.org/r/45406/#comment192155>
IF NOT Exists missing
metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql (line 7)
<https://reviews.apache.org/r/45406/#comment192148>
In MTable desc, it is int so its better to store it as int
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql (line 822)
<https://reviews.apache.org/r/45406/#comment192163>
inline statements here
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql (line 1)
<https://reviews.apache.org/r/45406/#comment192156>
if not exists
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql (line 1)
<https://reviews.apache.org/r/45406/#comment192158>
if not exists ?
- Ashutosh Chauhan
On April 12, 2016, 8:47 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45406/
> -----------------------------------------------------------
>
> (Updated April 12, 2016, 8:47 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Metastore Changes : API calls for retrieving primary keys and foreign keys information
>
>
> Diffs
> -----
>
> metastore/if/hive_metastore.thrift 6a55962
> metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
> metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
> metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
> metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
> metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
> metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
> metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
> metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
> metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
> metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
> metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
> metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
> metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
> metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
> metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
> metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
> metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
> metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
> metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
> metastore/src/model/package.jdo 7385a13
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
>
> Diff: https://reviews.apache.org/r/45406/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated April 12, 2016, 8:47 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/019-HIVE-13076.mssql.sql PRE-CREATION
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 64a26ac
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
metastore/src/model/org/apache/hadoop/hive/metastore/model/MConstraint.java PRE-CREATION
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated April 11, 2016, 5:45 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote 9a2322f
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated April 4, 2016, 8:45 p.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs (updated)
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java ac293b9
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java a73dbeb
metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 94ca835
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java b108f95
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf
metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated March 29, 2016, 12:11 a.m.)
Review request for hive and Ashutosh Chauhan.
Repository: hive-git
Description (updated)
-------
Metastore Changes : API calls for retrieving primary keys and foreign keys information
Diffs
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 8a8f8b1
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 6e5de20
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 3e7c6e7
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 97c07a5
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 2695ffa
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java bb6e584
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java 083d340
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java 9004457
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java bfd1206
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java 657bb7b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java ba059fe
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 2769845
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java adef415
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java de588e2
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java 6b08234
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeyRel.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java 5f8ce0d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java f88e279
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java 0236b4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java 89eb819
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java 2408ad1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java 8946635
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java 629c042
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java 9f57a4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleResponse.java 02c652a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalResponse.java c013e0e
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java b00fb9c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java d7dd8ec
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java 44d99c7
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java 488d3a0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java f39f582
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java fcbbd18
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java e11a2b3
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java a247221
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e8232b9
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 2c41912
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java f0c5ce1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 12ae66d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 8416369
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 2e903f1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java e1792bd
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java bba2d40
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java ab151b1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 7f8a044
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 75d0ebb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java d5a8d99
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6e334f6
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java afa832c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java b9b7f3c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java c32f50c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 938f06b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java d0daee5
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 78d4250
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 13e30db
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 14cd42e
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 05a0749
metastore/src/gen/thrift/gen-php/metastore/Types.php 488a920
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 516b926
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py ac8d8a4
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 10eaf4a
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1cf40ae
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e782bb5
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 35adb39
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/model/org/apache/hadoop/hive/metastore/model/MForeignKeyRel.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MPKFKMapping.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf
metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 45406: HIVE-13349: Metastore Changes : API calls
for retrieving primary keys and foreign keys information
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45406/
-----------------------------------------------------------
(Updated March 29, 2016, 12:10 a.m.)
Review request for hive and Ashutosh Chauhan.
Summary (updated)
-----------------
HIVE-13349: Metastore Changes : API calls for retrieving primary keys and foreign keys information
Repository: hive-git
Description
-------
Metastore Changes : HS2 changes : API calls for retrieving primary keys and foreign keys information
Diffs
-----
metastore/if/hive_metastore.thrift 6a55962
metastore/scripts/upgrade/derby/034-HIVE-13076.derby.sql PRE-CREATION
metastore/scripts/upgrade/derby/hive-schema-2.1.0.derby.sql 42f4eb6
metastore/scripts/upgrade/derby/upgrade-2.0.0-to-2.1.0.derby.sql a0bac3c
metastore/scripts/upgrade/mssql/hive-schema-2.1.0.mssql.sql cf5a662
metastore/scripts/upgrade/mssql/upgrade-2.0.0-to-2.1.0.mssql.sql f25daf2
metastore/scripts/upgrade/mysql/034-HIVE-13076.mysql.sql PRE-CREATION
metastore/scripts/upgrade/mysql/hive-schema-2.1.0.mysql.sql 6fd3209
metastore/scripts/upgrade/mysql/upgrade-2.0.0-to-2.1.0.mysql.sql e790636
metastore/scripts/upgrade/oracle/034-HIVE-13076.oracle.sql PRE-CREATION
metastore/scripts/upgrade/oracle/hive-schema-2.1.0.oracle.sql 774f6be
metastore/scripts/upgrade/oracle/upgrade-2.0.0-to-2.1.0.oracle.sql 8368d08
metastore/scripts/upgrade/postgres/033-HIVE-13076.postgres.sql PRE-CREATION
metastore/scripts/upgrade/postgres/hive-schema-2.1.0.postgres.sql 7463a37
metastore/scripts/upgrade/postgres/upgrade-2.0.0-to-2.1.0.postgres.sql 6172407
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 8a8f8b1
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 6e5de20
metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 3e7c6e7
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 97c07a5
metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 2695ffa
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddDynamicPartitions.java bb6e584
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsRequest.java 083d340
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AddPartitionsResult.java 9004457
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/AggrStats.java bfd1206
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ClearFileMetadataRequest.java 657bb7b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ColumnStatistics.java ba059fe
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java 2769845
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/DropPartitionsResult.java adef415
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java de588e2
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/FireEventRequest.java 6b08234
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ForeignKeyRel.java PRE-CREATION
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Function.java 5f8ce0d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetAllFunctionsResponse.java f88e279
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprRequest.java 0236b4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataByExprResult.java 89eb819
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataRequest.java 2408ad1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetFileMetadataResult.java 8946635
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsInfoResponse.java 629c042
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetOpenTxnsResponse.java 9f57a4a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetPrincipalsInRoleResponse.java 02c652a
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/GetRoleGrantsForPrincipalResponse.java c013e0e
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HeartbeatTxnRangeResponse.java b00fb9c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/HiveObjectRef.java d7dd8ec
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java 44d99c7
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/InsertEventRequestData.java 488d3a0
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/LockRequest.java f39f582
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/NotificationEventResponse.java fcbbd18
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/OpenTxnsResponse.java e11a2b3
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java a247221
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionListComposingSpec.java e8232b9
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionSpecWithSharedSD.java 2c41912
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionWithoutSD.java f0c5ce1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsByExprResult.java 12ae66d
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsRequest.java 8416369
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PartitionsStatsResult.java 2e903f1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java e1792bd
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrivilegeBag.java bba2d40
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PutFileMetadataRequest.java ab151b1
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/RequestPartsSpec.java 7f8a044
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java 75d0ebb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java d5a8d99
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SetPartitionsStatsRequest.java 6e334f6
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowCompactResponse.java afa832c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ShowLocksResponse.java b9b7f3c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java c32f50c
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java 938f06b
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsRequest.java d0daee5
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/TableStatsResult.java 78d4250
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 13e30db
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Type.java 14cd42e
metastore/src/gen/thrift/gen-php/metastore/ThriftHiveMetastore.php 05a0749
metastore/src/gen/thrift/gen-php/metastore/Types.php 488a920
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 516b926
metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py ac8d8a4
metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 10eaf4a
metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb 1cf40ae
metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb e782bb5
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java c9fadad
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java cdd12ab
metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 39cf927
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 06e9f78
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 35adb39
metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e49f757
metastore/src/model/org/apache/hadoop/hive/metastore/model/MForeignKeyRel.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MPKFKMapping.java PRE-CREATION
metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9
metastore/src/model/package.jdo 7385a13
metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 922a4bf
metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 2e1f5f4
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a46
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java e4723f6
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542
metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd0
Diff: https://reviews.apache.org/r/45406/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan