You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Nirmal Fernando <ni...@gmail.com> on 2014/08/20 06:25:33 UTC
6 PRs on the queue
Hi Stratos Committers,
We have 6 PRs on the queue. Anyone available for reviewing and merging
them?
https://github.com/apache/stratos/pulls
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: 6 PRs on the queue
Posted by Nirmal Fernando <ni...@gmail.com>.
All,
We have 10 PRs on the queue. Can we have some eyes on those please?
On Wed, Aug 20, 2014 at 11:48 AM, chris snow <ch...@gmail.com> wrote:
> I put a page on the wiki a while back:
>
>
> https://cwiki.apache.org/confluence/display/STRATOS/Committers+%3A+Applying+github+pull+requests
> On 20 Aug 2014 06:22, "Akila Ravihansa Perera" <ra...@wso2.com> wrote:
>
>> Hi Udara,
>>
>> You cannot merge directly to Github repo since that's only a mirror of
>> Apache git repo.
>>
>> However, you can still merge them by fetching from GitHub PR and then
>> pushing it to Apache git repo. Please refer to the 'merge GitHub PR'
>> thread that was initiated by Chris sometime back.
>>
>> Thanks.
>> On 20 Aug 2014 10:46, "Udara Liyanage" <ud...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> Do I have permission to merge PR. I don't see merge option.
>>>
>>>
>>> On Wed, Aug 20, 2014 at 10:11 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I'm in support currently, but will have a look as time permits
>>>>
>>>>
>>>> On Wed, Aug 20, 2014 at 9:55 AM, Nirmal Fernando <
>>>> nirmal070125@gmail.com> wrote:
>>>>
>>>>> Hi Stratos Committers,
>>>>>
>>>>> We have 6 PRs on the queue. Anyone available for reviewing and merging
>>>>> them?
>>>>>
>>>>> https://github.com/apache/stratos/pulls
>>>>>
>>>>> --
>>>>> Best Regards,
>>>>> Nirmal
>>>>>
>>>>> Nirmal Fernando.
>>>>> PPMC Member & Committer of Apache Stratos,
>>>>> Senior Software Engineer, WSO2 Inc.
>>>>>
>>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Udara Liyanage
>>>> Software Engineer
>>>> WSO2, Inc.: http://wso2.com
>>>> lean. enterprise. middleware
>>>>
>>>> web: http://udaraliyanage.wordpress.com
>>>> phone: +94 71 443 6897
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Udara Liyanage
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean. enterprise. middleware
>>>
>>> web: http://udaraliyanage.wordpress.com
>>> phone: +94 71 443 6897
>>>
>>
--
Best Regards,
Nirmal
Nirmal Fernando.
PPMC Member & Committer of Apache Stratos,
Senior Software Engineer, WSO2 Inc.
Blog: http://nirmalfdo.blogspot.com/
Re: 6 PRs on the queue
Posted by Udara Liyanage <ud...@wso2.com>.
I merged several previous PRs.
I will have a look again and try to merge.
Please have a descriptive commit message when sending PR coz it is very
helpful to understand what the PR actually does.
Touched, not typed. Erroneous words are a feature, not a typo.
Re: 6 PRs on the queue
Posted by chris snow <ch...@gmail.com>.
I put a page on the wiki a while back:
https://cwiki.apache.org/confluence/display/STRATOS/Committers+%3A+Applying+github+pull+requests
On 20 Aug 2014 06:22, "Akila Ravihansa Perera" <ra...@wso2.com> wrote:
> Hi Udara,
>
> You cannot merge directly to Github repo since that's only a mirror of
> Apache git repo.
>
> However, you can still merge them by fetching from GitHub PR and then
> pushing it to Apache git repo. Please refer to the 'merge GitHub PR'
> thread that was initiated by Chris sometime back.
>
> Thanks.
> On 20 Aug 2014 10:46, "Udara Liyanage" <ud...@wso2.com> wrote:
>
>> Hi,
>>
>> Do I have permission to merge PR. I don't see merge option.
>>
>>
>> On Wed, Aug 20, 2014 at 10:11 AM, Udara Liyanage <ud...@wso2.com> wrote:
>>
>>> Hi,
>>>
>>> I'm in support currently, but will have a look as time permits
>>>
>>>
>>> On Wed, Aug 20, 2014 at 9:55 AM, Nirmal Fernando <nirmal070125@gmail.com
>>> > wrote:
>>>
>>>> Hi Stratos Committers,
>>>>
>>>> We have 6 PRs on the queue. Anyone available for reviewing and merging
>>>> them?
>>>>
>>>> https://github.com/apache/stratos/pulls
>>>>
>>>> --
>>>> Best Regards,
>>>> Nirmal
>>>>
>>>> Nirmal Fernando.
>>>> PPMC Member & Committer of Apache Stratos,
>>>> Senior Software Engineer, WSO2 Inc.
>>>>
>>>> Blog: http://nirmalfdo.blogspot.com/
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Udara Liyanage
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean. enterprise. middleware
>>>
>>> web: http://udaraliyanage.wordpress.com
>>> phone: +94 71 443 6897
>>>
>>
>>
>>
>> --
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>
Re: 6 PRs on the queue
Posted by Akila Ravihansa Perera <ra...@wso2.com>.
Hi Udara,
You cannot merge directly to Github repo since that's only a mirror of
Apache git repo.
However, you can still merge them by fetching from GitHub PR and then
pushing it to Apache git repo. Please refer to the 'merge GitHub PR'
thread that was initiated by Chris sometime back.
Thanks.
On 20 Aug 2014 10:46, "Udara Liyanage" <ud...@wso2.com> wrote:
> Hi,
>
> Do I have permission to merge PR. I don't see merge option.
>
>
> On Wed, Aug 20, 2014 at 10:11 AM, Udara Liyanage <ud...@wso2.com> wrote:
>
>> Hi,
>>
>> I'm in support currently, but will have a look as time permits
>>
>>
>> On Wed, Aug 20, 2014 at 9:55 AM, Nirmal Fernando <ni...@gmail.com>
>> wrote:
>>
>>> Hi Stratos Committers,
>>>
>>> We have 6 PRs on the queue. Anyone available for reviewing and merging
>>> them?
>>>
>>> https://github.com/apache/stratos/pulls
>>>
>>> --
>>> Best Regards,
>>> Nirmal
>>>
>>> Nirmal Fernando.
>>> PPMC Member & Committer of Apache Stratos,
>>> Senior Software Engineer, WSO2 Inc.
>>>
>>> Blog: http://nirmalfdo.blogspot.com/
>>>
>>
>>
>>
>> --
>>
>> Udara Liyanage
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean. enterprise. middleware
>>
>> web: http://udaraliyanage.wordpress.com
>> phone: +94 71 443 6897
>>
>
>
>
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
Re: 6 PRs on the queue
Posted by Udara Liyanage <ud...@wso2.com>.
Hi,
Do I have permission to merge PR. I don't see merge option.
On Wed, Aug 20, 2014 at 10:11 AM, Udara Liyanage <ud...@wso2.com> wrote:
> Hi,
>
> I'm in support currently, but will have a look as time permits
>
>
> On Wed, Aug 20, 2014 at 9:55 AM, Nirmal Fernando <ni...@gmail.com>
> wrote:
>
>> Hi Stratos Committers,
>>
>> We have 6 PRs on the queue. Anyone available for reviewing and merging
>> them?
>>
>> https://github.com/apache/stratos/pulls
>>
>> --
>> Best Regards,
>> Nirmal
>>
>> Nirmal Fernando.
>> PPMC Member & Committer of Apache Stratos,
>> Senior Software Engineer, WSO2 Inc.
>>
>> Blog: http://nirmalfdo.blogspot.com/
>>
>
>
>
> --
>
> Udara Liyanage
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> web: http://udaraliyanage.wordpress.com
> phone: +94 71 443 6897
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897
Re: 6 PRs on the queue
Posted by Udara Liyanage <ud...@wso2.com>.
Hi,
I'm in support currently, but will have a look as time permits
On Wed, Aug 20, 2014 at 9:55 AM, Nirmal Fernando <ni...@gmail.com>
wrote:
> Hi Stratos Committers,
>
> We have 6 PRs on the queue. Anyone available for reviewing and merging
> them?
>
> https://github.com/apache/stratos/pulls
>
> --
> Best Regards,
> Nirmal
>
> Nirmal Fernando.
> PPMC Member & Committer of Apache Stratos,
> Senior Software Engineer, WSO2 Inc.
>
> Blog: http://nirmalfdo.blogspot.com/
>
--
Udara Liyanage
Software Engineer
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware
web: http://udaraliyanage.wordpress.com
phone: +94 71 443 6897