You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/27 14:35:05 UTC

[GitHub] [beam] damccorm commented on pull request #17432: [BEAM-11106] Support drain in Go SDK

damccorm commented on PR #17432:
URL: https://github.com/apache/beam/pull/17432#issuecomment-1111081314

   > Having converted this PR from draft to ready, a lot of changes were raw. Thanks for bearing with it!
   
   No problem, that's what PR reviews are for 😄 FWIW, a practice I've found really helpful is to do my own thorough PR review of any prs I convert from draft to ready (I'll often leave comments like I would if I was an external reviewer).
   
   With that said, this PR wasn't in bad shape or anything - I think it was/is pretty close to where it needed to be. I left a few more comments, but they are increasingly minor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org